chore(ui): Upgrade UI dependencies #384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #384 +/- ##
==========================================
- Coverage 68.09% 68.07% -0.02%
==========================================
Files 149 149
Lines 11809 11809
==========================================
- Hits 8041 8039 -2
- Misses 3030 3032 +2
Partials 738 738
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
deadlycoconuts
force-pushed
the
upgrade-ui
branch
from
55cb301
to
af1f1a8
Compare
deadlycoconuts
force-pushed
the
upgrade-ui
branch
from
7fbe71f
to
a7e507d
Compare
deadlycoconuts
force-pushed
the
upgrade-ui
branch
from
e2829e9
to
7a421b6
Compare
leonlnj
approved these changes
Jul 17, 2024
|
Thanks a lot for the quick review! And thanks @ariefrahmansyah for this PR too (I had to refer to the stuff you did for MLP and Merlin for some changes you had already done; sorry for all the crazy email notifications from all the git pushes 👀)! I've added the UI comments here, just like in XP: https://github.com/caraml-dev/turing/pull/384/files#diff-193b27d62e4fbda3d563009fed5ec6761a05f73558d94b39fab63ae948c679eaR5 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Similar to what had been done in MLP caraml-dev/mlp#100 and in Merlin caraml-dev/merlin#591, this PR updates certain UI dependencies in Turing, most notably:
package.jsonfile to pin the engine to >=20.13.1)EuiAccordion-related components; this is likely due a massive rework of the component in this PR [EuiAccordion] Split up rendering into sub-components & other cleanups elastic/eui#7161 but I've no idea why this change didn't affect the accordions in MerlinOther minor changes have also been made to the GitHub CICD files (more details are covered below and in the comments left on the diff itself).
Main Changes
GitHub Actions Updates
actions/upload-artifact- from v2 to v4 since the former has already been deprecated since the 30th of June this yearactions/download-artifact- from v2 to v4 since the former has already been deprecated since the 30th of June this year (the versions of this action andupload-artifactneed to be compatible to work)actions/checkout- from v3 to v4 since it's similarly done in the MLP repoactions/setup-go- from v4 to v5 since it's similarly done in the MLP repo (also provides caching)actions/setup-python- from v2 to v5 to keep it updated to the latest version (also provides caching)docker/login-action- from v1 to v3 just to keep it updated to the latest versionjupyterhub/action-k8s-await-workloads- from v1 to v3 just to keep it updated to the latest version