Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make images configurable in track/1.7 #308

Merged
merged 5 commits into from
Sep 27, 2023
Merged

make images configurable in track/1.7 #308

merged 5 commits into from
Sep 27, 2023

Conversation

NohaIhab
Copy link
Contributor

@NohaIhab NohaIhab commented Sep 26, 2023 •
edited
Loading

part of #307

Summary of changes:

  1. Cherry-picking commits to ensure images are configurable for airgapped environment.

Only the following commits were cherry-picked:

  1. Update tools/get-images.sh to match the script in main introduced in feat: get images on main #289

Testing get-images script

bash tools/get-images.sh
docker.io/kubeflownotebookswg/notebook-controller:v1.7.0
docker.io/kubeflownotebookswg/jupyter-web-app:v1.7.0
kubeflownotebookswg/jupyter-scipy:v1.7.0
kubeflownotebookswg/jupyter-pytorch-full:v1.7.0
kubeflownotebookswg/jupyter-pytorch-cuda-full:v1.7.0
kubeflownotebookswg/jupyter-tensorflow-full:v1.7.0
kubeflownotebookswg/jupyter-tensorflow-cuda-full:v1.7.0
swr.cn-south-1.myhuaweicloud.com/mindspore/jupyter-mindspore:v1.6.1
kubeflownotebookswg/codeserver-python:v1.7.0
kubeflownotebookswg/rstudio-tidyverse:v1.7.0

NohaIhab and others added 3 commits September 26, 2023 08:32
@NohaIhab @ca-scribner
feat: Dynamic Notebook Image Selector (#259)
aa52ee4 
* Initial implementation: Dynamic Notebook Image Selector
* add jupyter-images, vscode-images, rstudio-images config with default
* change spawner file to Jinja template
* render spawner template with config
* seperate pushing the spawner from pushing the logos files
* feat:  integration test for notebook selector config
* feat: unit tests coverage
* refactor: use charm functionaility to get spawner_ui_config
* refactor: parametrize integration test
* refactor: use arrange-act-assert pattern for unit tests

---------

Co-authored-by: Andrew Scribner <[email protected]>
@phoevos @NohaIhab
fix: Add scipy to the UI jupyter-images list (#291)
ae70c55 
Add `kubeflownotebookswg/jupyter-scipy:v1.7.0` to the list of
jupyter-images exposed as a configurable option via the jupyter-ui
charm. Adding it to the top of the list restores it as the default
option.

Signed-off-by: Phoevos Kalemkeris <[email protected]>
@NohaIhab
fix: update get-images.sh script for configurable images
7a010f1
@NohaIhab NohaIhab requested a review from a team as a code owner September 26, 2023 09:47
DnPlas
DnPlas approved these changes Sep 27, 2023
View reviewed changes
Copy link
Contributor

@DnPlas DnPlas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, thanks @NohaIhab and @orfeas-k

@orfeas-k orfeas-k merged commit 72357e6 into track/1.7 Sep 27, 2023
14 checks passed
@orfeas-k orfeas-k deleted the kf-4445-make-images-configurable branch September 27, 2023 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@i-chvets i-chvets i-chvets left review comments

@DnPlas DnPlas DnPlas approved these changes

Assignees
No one assigned
Labels
Libraries: Out of sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@NohaIhab @DnPlas @i-chvets @orfeas-k @phoevos