fix: remove unavailable mindspore image (#293)

canonical · Sep 5, 2023 · 017a4ef · 017a4ef
1 parent eaca4e7
commit 017a4ef
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 8 deletions.
diff --git a/charms/jupyter-ui/config.yaml b/charms/jupyter-ui/config.yaml
@@ -27,7 +27,6 @@ options:
       - kubeflownotebookswg/jupyter-pytorch-cuda-full:v1.7.0
       - kubeflownotebookswg/jupyter-tensorflow-full:v1.7.0
       - kubeflownotebookswg/jupyter-tensorflow-cuda-full:v1.7.0
-      - swr.cn-south-1.myhuaweicloud.com/mindspore/jupyter-mindspore:v1.6.1
     description: list of image options for Jupyter Notebook
   rstudio-images:
     type: string

diff --git a/charms/jupyter-ui/tests/unit/test_operator.py b/charms/jupyter-ui/tests/unit/test_operator.py
@@ -52,13 +52,6 @@ def test_spawner_ui(self, k8s_resource_handler: MagicMock, harness: Harness):
         config_value = spawner_ui_config["spawnerFormDefaults"]["configurations"]["value"]
         assert config_value == ["access-ml-pipeline"]
 
-        # test for images added in addition to upstream
-        image_list = spawner_ui_config["spawnerFormDefaults"]["image"]["options"]
-        assert any(
-            "swr.cn-south-1.myhuaweicloud.com/mindspore/jupyter-mindspore" in image
-            for image in image_list
-        )
-
     @patch("charm.KubernetesServicePatch", lambda x, y, service_name: None)
     @patch("charm.JupyterUI.k8s_resource_handler")
     def test_not_leader(self, k8s_resource_handler: MagicMock, harness: Harness):