Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

charming-actions/upload-charm action is uploading images incorrectly and affecting charms' functionality #962

Closed
DnPlas opened this issue Jul 1, 2024 · 3 comments
Closed

charming-actions/upload-charm action is uploading images incorrectly and affecting charms' functionality #962

DnPlas opened this issue Jul 1, 2024 · 3 comments
Labels
bug Something isn't working

Comments

@DnPlas
Copy link
Contributor

DnPlas commented Jul 1, 2024

Bug Description

It appears that canonical/charming-actions#139 is affecting some charms' functionality:

We need to investigate how this issue is affecting us:

  • How images get attached to charms?
  • How is this affecting tracks?
  • How can we be sure about which image is attached to a certain charm revision?

To Reproduce

canonical/charming-actions#139 contains all the necessary information.

Environment

CI environment.

Relevant Log Output

https://github.com/canonical/charming-actions/issues/139 contains all the necessary information.

Additional Context

No response
@DnPlas DnPlas added the bug Something isn't working label Jul 1, 2024
@syncronize-issues-to-jira Syncronize issues to Jira
Copy link

Thank you for reporting us your feedback!

The internal ticket has been created: https://warthogs.atlassian.net/browse/KF-5952.

This message was autogenerated

@orfeas-k orfeas-k mentioned this issue Jul 2, 2024
Closed
@orfeas-k
Copy link
Contributor

orfeas-k commented Jul 4, 2024

Doing some investigation after canonical/charming-actions#139 (comment) comment where they suggest that this change took place back in November 2023, I think I 've found another place where this has bitten us (and probably there is more)

Kserve-controller

Looking at repo's releases, I see the following:

Revision 561

resources:

  • kube-rbac-proxy-image: gcr.io/kubebuilder/kube-rbac-proxy:v0.13.1
    resource-revision: 441
  • kserve-controller-image: charmedkubeflow/kserve-controller:0.13.0-e151c86
    resource-revision: 446

Revision 558

resources:

  • kube-rbac-proxy-image: gcr.io/kubebuilder/kube-rbac-proxy:v0.13.1
    resource-revision: 441
  • kserve-controller-image: kserve/kserve-controller:v0.13.0
    resource-revision: 446

and taking a look at the CI runs:

they have images with different hash but they are being released with the same resource-revision.

This was referenced Jul 4, 2024
Merged
Merged
@DnPlas
Copy link
Contributor Author

DnPlas commented Jul 5, 2024

It looks like this issue is also affecting the PR tracks and the "stable" tracks (e.g. track/2.0 -> 2.0/stable)

@orfeas-k orfeas-k mentioned this issue Jul 10, 2024
Merged
orfeas-k added a commit to canonical/charming-actions that referenced this issue Jul 10, 2024
@orfeas-k
fix(upload-charm): Use resource revision from upload-resource command (…
46fe0c6 
…#147)

Use resource revision number returned by upload-resource command when
uploading a charm with resources. This replaces the previous behaviour
when the action was listing resources and was using the latest
available.

Closes #139
Ref canonical/bundle-kubeflow#962
This was referenced Jul 10, 2024
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
orfeas-k added a commit to canonical/admission-webhook-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action to 2.6.2 (#142)
93e8839 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/argo-operators that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#184)
535aae7 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/argo-operators that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#184)
2c23e15 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/dex-auth-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#205) (#207)
bb8577c 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/envoy-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action to 2.6.2 (#119)
d8916ea 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/katib-operators that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#212) (#215)
180c31f 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/kfp-operators that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#536) (#537)
48f6cce 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/knative-operators that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#197) (#199)
177ffa6 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/kserve-operators that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#251) (#253)
1cc56db 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/kubeflow-dashboard-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#210) (#212)
348f6cd 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/kubeflow-profiles-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#172) (#173)
463eff0 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/kubeflow-roles-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#87) (#89)
94faa17 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/kubeflow-tensorboards-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#119) (#121)
c2ea5e6 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/kubeflow-volumes-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#140) (#142)
ba8627b 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/metacontroller-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#114) (#116)
a5b18b4 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/minio-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#175) (#177)
f6553ae 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/mlmd-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#89) (#91)
5f207f4 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/notebook-operators that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#387) (#388)
de0a04d 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/oidc-gatekeeper-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#160) (#162)
1c0ac71 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/resource-dispatcher that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#54) (#56)
af0ba8c 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/seldon-core-operator that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#260) (#261)
ad4ac03 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/argo-operators that referenced this issue Jul 15, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#184) (#186)
bc61fd2 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/istio-operators that referenced this issue Jul 25, 2024
@orfeas-k
ci: bump upload-charm action to 2.6.2 (#473)
a43411f 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/istio-operators that referenced this issue Jul 25, 2024
@orfeas-k
ci: bump upload-charm action to 2.6.2 (#472)
e2bd07a 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/istio-operators that referenced this issue Jul 25, 2024
@orfeas-k
ci: bump upload-charm action to 2.6.2 (#470)
926933e 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/istio-operators that referenced this issue Jul 25, 2024
@orfeas-k
ci: bump upload-charm action 2.4.0 -> 2.6.2 (#466)
4fb213d 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/istio-operators that referenced this issue Jul 25, 2024
@orfeas-k
ci: bump upload-charm action to 2.6.2 (#471)
737e0cb 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/istio-operators that referenced this issue Jul 26, 2024
@orfeas-k
ci: bump upload-charm action to 2.6.2 (#469)
3c56afa 
Ref canonical/bundle-kubeflow#962
orfeas-k added a commit to canonical/istio-operators that referenced this issue Jul 26, 2024
@orfeas-k
ci: bump upload-charm action to 2.6.2 (#474)
d0edd4e 
Ref canonical/bundle-kubeflow#962
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@DnPlas @orfeas-k