fix(upload-charm): Use resource revision from upload-resource command #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use resource revision number returned by upload-resource command when uploading a charm with resources. This replaces the previous behaviour when the action was listing resources and was using the latest available.
simskij
approved these changes
Jul 10, 2024
taurus-forever
referenced
this pull request
in canonical/mysql-router-k8s-operator
Sep 17, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [canonical/charming-actions](https://redirect.github.com/canonical/charming-actions) | action | patch | `2.6.0` -> `2.6.3` | --- ### Release Notes <details> <summary>canonical/charming-actions (canonical/charming-actions)</summary> ### [`v2.6.3`](https://redirect.github.com/canonical/charming-actions/releases/tag/2.6.3) [Compare Source](https://redirect.github.com/canonical/charming-actions/compare/2.6.2...2.6.3) #### What's Changed - fix(upload-bundle): Implement the same functionality without using `juju-bundle` by [@​mvlassis](https://redirect.github.com/mvlassis) in [https://github.com/canonical/charming-actions/pull/151](https://redirect.github.com/canonical/charming-actions/pull/151) #### New Contributors - [@​mvlassis](https://redirect.github.com/mvlassis) made their first contribution in [https://github.com/canonical/charming-actions/pull/151](https://redirect.github.com/canonical/charming-actions/pull/151) **Full Changelog**: canonical/charming-actions@2.6.2...2.6.3 ### [`v2.6.2`](https://redirect.github.com/canonical/charming-actions/releases/tag/2.6.2) [Compare Source](https://redirect.github.com/canonical/charming-actions/compare/2.6.1...2.6.2) #### What's Changed - fix(upload-charm): Use resource revision from upload-resource command by [@​orfeas-k](https://redirect.github.com/orfeas-k) in [https://github.com/canonical/charming-actions/pull/147](https://redirect.github.com/canonical/charming-actions/pull/147) #### New Contributors - [@​orfeas-k](https://redirect.github.com/orfeas-k) made their first contribution in [https://github.com/canonical/charming-actions/pull/147](https://redirect.github.com/canonical/charming-actions/pull/147) **Full Changelog**: canonical/charming-actions@2.6.1...2.6.2 ### [`v2.6.1`](https://redirect.github.com/canonical/charming-actions/releases/tag/2.6.1) [Compare Source](https://redirect.github.com/canonical/charming-actions/compare/2.6.0...2.6.1) #### What's Changed - Support charms using charmcraft extensions by [@​weiiwang01](https://redirect.github.com/weiiwang01) in [https://github.com/canonical/charming-actions/pull/142](https://redirect.github.com/canonical/charming-actions/pull/142) #### New Contributors - [@​weiiwang01](https://redirect.github.com/weiiwang01) made their first contribution in [https://github.com/canonical/charming-actions/pull/142](https://redirect.github.com/canonical/charming-actions/pull/142) **Full Changelog**: canonical/charming-actions@2.6.0...2.6.1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 1am and before 3am every weekday" in timezone Etc/UTC, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR was generated by [Mend Renovate](https://mend.io/renovate/). View the [repository job log](https://developer.mend.io/github/canonical/mysql-router-k8s-operator). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy40MjEuOSIsInVwZGF0ZWRJblZlciI6IjM4LjU5LjIiLCJ0YXJnZXRCcmFuY2giOiJtYWluIiwibGFiZWxzIjpbXX0=--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use resource revision number returned by upload-resource command when uploading a charm with resources. This replaces the previous behaviour when the action was listing resources and was using the latest available.
The issue below documents why we need this change and why this change works. In short, the root cause is that Charmhub changed its behavior at some point and running
charmcraft upload-resourcedoes not create a new resource revision, breaking essentially the action which previously rancharmcraft upload-resourcefollowed bycharmcraft resource-revisionsand was attaching the latest available to the charm.Here's an example run using the action from the PR's branch.
Closes #139
Ref canonical/bundle-kubeflow#962
Note that this PR does not touch the action's behavior where
upload-imageis set toFalse, given that this is a different use-case and its behavior wasn't altered by the aforementioned Charmhub change (it was just using thelatestresource revision number available without uploading anything). We contacted however the people using it (operator-workflows repo ) to give them a heads up of the change.