chore: integrate 2.2.0 rocks #520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: Out of sync
Libraries: OK
labels
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: Out of sync
Libraries: OK
labels
github-actions
bot
added
Libraries: OK
Libraries: Out of sync
and removed
Libraries: OK
Libraries: Out of sync
labels
|
Re-running the CI because the error is a known issue with building a dependency package and it should not be related with the changes in this PR. |
DnPlas
reviewed
Jul 4, 2024
DnPlas
reviewed
Jul 5, 2024
DnPlas
reviewed
Jul 5, 2024
There was a problem hiding this comment.
Thanks @orfeas-k !
Just a super minor comment, other than that LGTM.
I have done the following to ensure the charms and workloads are working as expected:
Env
microk8s: 1.29-strict/stable
juju: 3.4/stable (3.4.4)
addons: dns hostpath-storage metallb:10.64.140.43-10.64.140.49
Testing steps
- Deploy CKF from latest/edge
juju deploy kubeflow --channel latest/edge --trust - Refresh kfp-operators to this PR e.g.
juju refresh kfp-api --channel latest/edge/pr-520 - Because
charming-actions/upload-charmaction is uploading images incorrectly and affecting charms' functionality bundle-kubeflow#962 is affecting the release job, I had to manually update the oci-image of all charmsjuju refresh kfp-api --resource oci-image=<image from this PR> - Waited for everything to settle and created runs and experiments.
- Everything seems to be working fine (runs are scheduled and executed, artefacts are accessible, experiments and runs can be created). The only thing that is not working is recurring runs because of KFP Recurrings Runs not working on kubeflow 1.8 #517, but it should be fixed by Change namespace in kfp-schedwf #529 for
latest/edge.
github-actions
bot
added
Libraries: Out of sync
Libraries: OK
and removed
Libraries: OK
Libraries: Out of sync
labels
DnPlas
approved these changes
Jul 8, 2024
mvlassis
pushed a commit
that referenced
this pull request
Jul 9, 2024
mvlassis
pushed a commit
that referenced
this pull request
Jul 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes canonical/pipelines-rocks#94
Closes canonical/pipelines-rocks#95
Closes canonical/pipelines-rocks#96
Closes canonical/pipelines-rocks#97
Closes canonical/pipelines-rocks#98
Closes canonical/pipelines-rocks#99