-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Delete buf protoc
#915
Merged
Merged
Delete buf protoc
#915
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doriable
approved these changes
Feb 4, 2022
mfridman
approved these changes
Feb 4, 2022
This was referenced Feb 4, 2022
loredanacirstea
added a commit
to evmos/evmos
that referenced
this pull request
Apr 6, 2022
12 tasks
fedekunze
added a commit
to evmos/evmos
that referenced
this pull request
Apr 29, 2022
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
19 tasks
SuperVenus0725
added a commit
to loveFeynman/cascadia_evm_chain
that referenced
this pull request
Jan 9, 2023
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
SuperVenus0725
pushed a commit
to loveFeynman/cascadia_evm_chain
that referenced
this pull request
Jan 9, 2023
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
SuperVenus0725
pushed a commit
to SuperVenus0725/evm_chain
that referenced
this pull request
Jan 9, 2023
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
Monirul1
pushed a commit
to Monirul1/buf
that referenced
this pull request
Apr 30, 2023
T0psecurity
added a commit
to T0psecurity/cascadia-chain
that referenced
this pull request
May 10, 2023
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
supersenior017
added a commit
to supersenior017/evm_chain
that referenced
this pull request
Aug 16, 2023
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
niceDeve
added a commit
to niceDeve/cascadia_evm_chain
that referenced
this pull request
Sep 1, 2023
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
niceDeve
added a commit
to niceDeve/cascadia-chain
that referenced
this pull request
Sep 2, 2023
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
jacksonmori755
added a commit
to jacksonmori755/cascadia-chain
that referenced
this pull request
Sep 13, 2023
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
kingpig-dev
added a commit
to kingpig-dev/cascadia-chain
that referenced
this pull request
Feb 19, 2024
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
slickcharmer
added a commit
to slickcharmer/evmos
that referenced
this pull request
Mar 20, 2024
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
dannyboy820
added a commit
to dannyboy820/cascadia_evm_chain
that referenced
this pull request
Jul 16, 2024
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
lovenoble
added a commit
to lovenoble/evmos
that referenced
this pull request
Jul 23, 2024
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
dannyboy-820
added a commit
to dannyboy-820/cascadia_evm_chain
that referenced
this pull request
Jul 29, 2024
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
ranupthestairs
added a commit
to ranupthestairs/cascadia-chain
that referenced
this pull request
Sep 30, 2024
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
togetherAll7
pushed a commit
to togetherAll7/evmos
that referenced
this pull request
Nov 18, 2024
bufbuild/buf#915 Co-authored-by: Federico Kunze Küllmer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR effectively deletes
buf protoc
.buf protoc
was added to demonstrate to users thatbuf
actually does produce equivalent compilation results toprotoc
, and to give them a mechanism to verify this. However,protoc
is a poor experience for working with Protobuf - this poor experience is part of whybuf
exists. The experience is so sufficiently different (and difficult to isolate) that we have what amounts to a very different internal code path to setup the compilation. These differences result in a maintenance burden for something that we want to deprecate in the first place.Issues are piling up that we don't have bandwidth to address anytime soon:
buf protoc
#776protoc
not resolving arguments using include paths #353buf protoc
#351buf protoc
andprotoc
#496We want to spend our time fixing the Protobuf experience as a whole, not maintaining something that isn't a great experience in the first place. As such, we're removing
buf protoc
pre-v1.0.What this PR actually does is moves
buf protoc
tobuf alpha protoc
.buf alpha
is a hidden, completely experimental sub-command that has zero guarantees - in fact, we expect most of the commands underbuf alpha
to be deleted at some point. Havingbuf alpha protoc
is useful forbuf
development at times as when we get a compilation issue, we can directly compareprotoc
andbuf alpha protoc
results to see if the issue is also present inprotoc
. If this usefulness wanes over time, and/or we have sufficient need to delete the divergent codepaths, we can delete it outright.An alternative was to split this out into a separate
buf-protoc
orprotoc-buf
binary, that either lives here or in another repository, but this would seem to incur even more maintenance.Few users are using
buf protoc
itself, and the mitigation is trivial: go back to using mainlineprotoc
.buf protoc
itself requires mainlineprotoc
to be installed anyways if using any of the builtin plugins (--java_out, --cpp_out
, etc).