Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete buf protoc #915

Merged
merged 4 commits into from
Feb 4, 2022
Merged

Delete buf protoc #915

merged 4 commits into from
Feb 4, 2022

Conversation

bufdev
Copy link
Member

@bufdev bufdev commented Feb 4, 2022

This PR effectively deletes buf protoc.

buf protoc was added to demonstrate to users that buf actually does produce equivalent compilation results to protoc, and to give them a mechanism to verify this. However, protoc is a poor experience for working with Protobuf - this poor experience is part of why buf exists. The experience is so sufficiently different (and difficult to isolate) that we have what amounts to a very different internal code path to setup the compilation. These differences result in a maintenance burden for something that we want to deprecate in the first place.

Issues are piling up that we don't have bandwidth to address anytime soon:

We want to spend our time fixing the Protobuf experience as a whole, not maintaining something that isn't a great experience in the first place. As such, we're removing buf protoc pre-v1.0.

What this PR actually does is moves buf protoc to buf alpha protoc. buf alpha is a hidden, completely experimental sub-command that has zero guarantees - in fact, we expect most of the commands under buf alpha to be deleted at some point. Having buf alpha protoc is useful for buf development at times as when we get a compilation issue, we can directly compare protoc and buf alpha protoc results to see if the issue is also present in protoc. If this usefulness wanes over time, and/or we have sufficient need to delete the divergent codepaths, we can delete it outright.

An alternative was to split this out into a separate buf-protoc or protoc-buf binary, that either lives here or in another repository, but this would seem to incur even more maintenance.

Few users are using buf protoc itself, and the mitigation is trivial: go back to using mainline protoc. buf protoc itself requires mainline protoc to be installed anyways if using any of the builtin plugins (--java_out, --cpp_out, etc).

@bufdev bufdev merged commit 408786d into main Feb 4, 2022
@bufdev bufdev deleted the buf-alpha-protoc branch February 4, 2022 17:06
loredanacirstea added a commit to evmos/evmos that referenced this pull request Apr 6, 2022
fedekunze added a commit to evmos/evmos that referenced this pull request Apr 29, 2022
SuperVenus0725 added a commit to loveFeynman/cascadia_evm_chain that referenced this pull request Jan 9, 2023
SuperVenus0725 pushed a commit to loveFeynman/cascadia_evm_chain that referenced this pull request Jan 9, 2023
SuperVenus0725 pushed a commit to SuperVenus0725/evm_chain that referenced this pull request Jan 9, 2023
Monirul1 pushed a commit to Monirul1/buf that referenced this pull request Apr 30, 2023
T0psecurity added a commit to T0psecurity/cascadia-chain that referenced this pull request May 10, 2023
supersenior017 added a commit to supersenior017/evm_chain that referenced this pull request Aug 16, 2023
niceDeve added a commit to niceDeve/cascadia_evm_chain that referenced this pull request Sep 1, 2023
niceDeve added a commit to niceDeve/cascadia-chain that referenced this pull request Sep 2, 2023
jacksonmori755 added a commit to jacksonmori755/cascadia-chain that referenced this pull request Sep 13, 2023
kingpig-dev added a commit to kingpig-dev/cascadia-chain that referenced this pull request Feb 19, 2024
slickcharmer added a commit to slickcharmer/evmos that referenced this pull request Mar 20, 2024
dannyboy820 added a commit to dannyboy820/cascadia_evm_chain that referenced this pull request Jul 16, 2024
lovenoble added a commit to lovenoble/evmos that referenced this pull request Jul 23, 2024
dannyboy-820 added a commit to dannyboy-820/cascadia_evm_chain that referenced this pull request Jul 29, 2024
ranupthestairs added a commit to ranupthestairs/cascadia-chain that referenced this pull request Sep 30, 2024
togetherAll7 pushed a commit to togetherAll7/evmos that referenced this pull request Nov 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants