chore: fix protocgen.sh wrt buf's latest version
#16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vitsalis
reviewed
Jun 16, 2022
There was a problem hiding this comment.
Running make proto-gen based on this change leads to the following error:
>>> make proto-gen
Generating Protobuf files
Error: unknown command "alpha" for "buf"
Run 'buf --help' for usage.
unknown command "alpha" for "buf"
make: *** [proto-gen] Error 1
A thing to consider is that this script is run inside a Docker container built on the tendermintdev/sdk-proto-gen image that is maintained by Tendermint (see Makefile).
|
I see, closed this PR then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
protocgen.shscript usesbuf protocsubcommand. This subcommand has been removed and replaced bybuf alpha protocin v1.0.0 (2022-02-17), as per https://github.com/bufbuild/buf/blob/main/CHANGELOG.md#v100---2022-02-17 and bufbuild/buf#915.