Release: 0.21.0-beta

[Rjected]

There have been a few significant PRs since 0.20.1-beta, notably #1509, #1502, #1500, and #1467, so it might be time for a small release.
This issue is here to track PRs that we might want to add to a new release, and also gather opinions about having one.
People who's opinions I'd like to get on this:
@jcvernaleo
@jakesyl
@torkelrogstad
and anyone else who is interested.

[jcvernaleo]

Sounds to me like a release might be worth while based on that.

Which leaves the question, are there any other PRs we need to squeeze in before doing a release (assuming no one objects to a release).

[Rjected]

Looking at stuff that's been reviewed, #1393 and #1410 both seem very simple, and are reviewed. There's also #1556 which you've approved and #1558 which is not too large, take a look if you have time. I'm prioritizing suggesting things that either are not too large or have already been reviewed and are ready (pass travis, aren't outdated or might need a second look). Let me know what you think about these.

[Rjected]

Also for the version number, it turns out that #1467 is breaking/non-backwards-compatible since exported types and function definitions have been changed, meaning it's 0.21.0-beta rather than 0.20.2-beta. semver.org is referenced in version.go and the version number is compatible with the spec, if we stick to this I think we resolve part of #1545.

[wpaulino]

#1560 is required to address a bug introduced in #1529.

[jakesylvestre]

I'm actually thinking a more granular release cycle around semver might be a good idea as we play catch up here- would love to hear everyone else's opinions though

[jcvernaleo]

@wpaulino #1560 has changes requested by @Roasbeef so he will need to accept the changes (or the explanation) before that one can go in.

[wpaulino]

I would also like to suggest #1577 to provide backwards compatibility for applications that depend on rpcclient and communicate with btcd backends which have not been updated to handle the new getblock request format.

[onyb]

Release notes draft

I came up with a draft release notes for 0.21.0-beta, to help with the process. I'm sure we can improve it, so feedback on the wording/style is most welcome.

It seems we have ironed out all the issues discussed above, and the changeset is already large enough for a minor release. 💪

Network-related changes:

• Handle notfound messages from peers in netsync package. (server: handle notfound #1603)

RPC changes:

• The Verbose and VerboseTx boolean fields in btcjson.GetBlockCmd have been replaced with a single integer field called Verbosity, to reflect the new getblock RPC call parameters introduced in Bitcoin Core 0.15.0. (Refactor GetBlockVerboseTx to reflect correct getblock RPC call parameters. #1529)

  The getblock RPC server command in btcd has also been updated with this change.
  Backwards compatibility has been maintained in rpcclient. (rpcclient: send legacy GetBlock request for backwards compatibility #1577)

• Added an optional Params field to rpcclient.ConnConfig, to represent the network that the server is running. (rpcclient: Add net params to Client #1467)

• Added a new error code ErrRPCInWarmup in btcjson. (btcjson: add RPC_IN_WARMUP error code #1541)

• Updated btcjson.GetMempoolEntryResult to reflect the new getmempoolentry response in Bitcoin Core 0.19.0. (update GetMempoolEntryResult to v0.19.0 #1524)

• Implemented rpcclient methods to invoke estimatesmartfee and generatetoaddress JSON-RPC commands. (Add generatetoaddress and estimatesmartfee RPC calls #1500)

• Implemented rpcclient method to invoke getblockstats JSON-RPC command. (Add generatetoaddress and estimatesmartfee RPC calls #1500)

• Parse serialized transaction from createrawtransaction JSON-RPC command using both segwit, and legacy format. (Try both TX serialization formats in createrawtransaction #1502)

• Support cookie-based authentication using a new CookiePath field in rpcclient.ConnConfig. (rpcclient: Add cookie auth #1460)

• Implemented rpcclient method to invoke getchaintxstats JSON-RPC command. (rpcclient: Add getchaintxstats JSON-RPC client command #1571)

• Implemented rpcclient method to invoke fundrawtransaction JSON-RPC command. (Add fundrawtransaction RPC call #1553)

• Implemented rpcclient method to invoke getbalances JSON-RPC command. (Add getbalances RPC client command #1595)

• Added a new method rpcclient.GetTransactionWatchOnly to support passing the include_watchonly argument to gettransaction JSON-RPC command. (rpcclient: Add GetTransactionWatchOnly method #1592)

Crypto changes:

• Fixed panic in fieldVal.SetByteSlice when called with a value larger than 32 bytes. The improved version is approximately 35% faster. (btcec: Avoid panic in fieldVal.SetByteSlice for large inputs #1602)

btcctl changes:

• Added -regtest mode to btcctl. (btcctl: add regtest mode to btcctl #1556)

Misc changes:

• Fixed a bug due to a deadlock in connmgr's dynamic ban scoring. (BUG:dynamicbanscore deadlock #1509)
• Replaced TravisCI with GitHub Actions. (build: multiple cleanups #1575)
• Improved chain state init efficiency. (Improve chain state init efficiency #1580)
• Added blockchain.NewUtxoEntry() to directly create entries for UtxoViewpoint. (Add blockchain.NewUtxoEntry()  #1588)
• Switch to a generic LRU implementation in the peer package, from decred/dcrd. (peer: use generic lru #1599)

[jcvernaleo]

Release notes look good to me. I think we are have enough in to go ahead with a release. If anyone objects or things something else desperately needs to go in, comment here, but if not, we'll go forward in a few days.

[onyb]

I have updated the release notes above with the recent PRs that were merged. I think we should include #1608 too since it updates the docs for #1529 (part of the release).

I also want to suggest cutting a new release for btcutil, and bumping the version in btcd's go.mod. The release process for btcutil is practically non-existent (no release notes, no signed binaries, etc), however, I prepared the release notes for a v1.1.0 here.

Releasing btcutil will involve creating two tags/releases:

• v1.1.0
• psbt/v1.1.0

What do you guys think? cc: @jcvernaleo

[jcvernaleo]

100% agree on #1608

Hadn't thought about btcutil but I suspect you are correct there too. Will check out your release notes there.

[Roasbeef]

The release process for btcutil is practically non-existent (no release

notes, no signed binaries, etc), There aren't signed binaries as it's a package/library. One PR we should consider landing before the next btcutil version is tagged (so far we usually tag one around the same time we release an lnd version), is this PR: btcsuite/btcutil#178. It'll allow our PSBT lib to once again be compatible with wallet software that requires the additional information for verification purposes.

…

On Wed, Jul 22, 2020 at 1:46 PM Anirudha Bose ***@***.***> wrote: I have updated the release notes above with the recent PRs that were merged. I think we should include #1608 <#1608> too since it updates the docs for #1529 <#1529> (part of the release). I also want to suggest cutting a new release for btcutil <https://github.com/btcsuite/btcutil/>, and bumping the version in btcd's go.mod. The release process for btcutil is practically non-existent (no release notes, no signed binaries, etc), however, I prepared the release notes for a *v1.1.0* here <https://gist.github.com/onyb/d0c91f1fbe82f46e8223e1eac3d4f5af>. Releasing btcutil will involve creating two tags/releases: - v1.1.0 - psbt/v1.1.0 What do you guys think? cc: @jcvernaleo <https://github.com/jcvernaleo> — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#1572 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAHTWLVPSM7I6D6LSZB6OWTR45F2ZANCNFSM4M7CTILA> .

[wenweih]

Changes has been approved, may I ask is there any plan to release 0.21.0, thanks.

[jcvernaleo]

@wenweih yes, 0.21.0 will be released soon. I was without internet or power for most of last week so that pushed my schedule back a bit but I'm catching up.

[jcvernaleo]

See #1620 for version bump for this release.

[jakesylvestre]

I haven't used windows in a few years, but looks like #1023 is still an issue (msi installer). Should probably address that (or drop support) in the release process

[jcvernaleo]

I think the release process just generates an exe (at least the way I remember it). The msi used to be a totally separate process.

[jcvernaleo]

Release is done:
https://github.com/btcsuite/btcd/releases/tag/v0.21.0-beta