Add generatetoaddress and estimatesmartfee RPC calls #1500
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
torkelrogstad
force-pushed
the
2019-11-26-rpc-calls
branch
from
e9546ac
to
7c405be
Compare
octobocto
reviewed
Dec 6, 2019
rpcclient/mining.go
Outdated
| return c.sendCmd(cmd) | ||
| } | ||
|
|
||
| // Generate generates numBlocks blocks to the given address and returns their hashes. |
There was a problem hiding this comment.
Other than this looks good to go
|
LGTM |
|
Can we get this merged in? |
|
Agreed, need this too |
|
@Roasbeef this PR seems to be needed quite a bit by the community, Any chance of getting this in? |
|
jcvernaleo
requested changes
Mar 16, 2020
torkelrogstad
force-pushed
the
2019-11-26-rpc-calls
branch
from
7c405be
to
d0fa6c6
Compare
|
I've squashed the commits and updated the comment. I also updated |
jakesylvestre
approved these changes
Mar 17, 2020
Closed
|
Why is POST http://my-btcd:8334
{
"jsonrpc": "2.0",
"id": "xyz",
"method": "estimatesmartfee",
"params": [
6
]
}{
"jsonrpc": "2.0",
"result": null,
"error": {
"code": -32601,
"message": "Method not found"
},
"id": "xyz"
}Running https://github.com/btcsuite/btcd/releases/tag/v0.22.0-beta |
|
This PR implemented this in the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Once this PR is merged I'll open up another PR for implementing the
fundrawtransactionRPC call. It is implemented at arcanetechnology#2, but it needsEstimateSmartFeeModefrom this PR for a clean backport.