build: multiple cleanups #1575
build: multiple cleanups #1575
Conversation
test go 1.14 use golangci-lint
|
It will activate on merge. |
|
Ah, cool. Will still need one of those guys to fix the branch protections though. |
|
You'll have to disable the continuous-intergration/travis-ci requirement first. |
| @@ -271,7 +271,7 @@ type GetBlockTemplateResult struct { | |||
|
|
|||
| type MempoolFees struct { | |||
| Base float64 `json:"base"` | |||
| Modified float64 `json:"base"` | |||
| Modified float64 `json:"modified"` | |||
There was a problem hiding this comment.
Good catch, I think this had been around since the struct was introduced.
| github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f h1:bAs4lUbRJpnnkd9VhRV3jjAVU7DJVjMaK+IsvSeZvFo= | ||
| github.com/btcsuite/btclog v0.0.0-20170628155309-84c8d2346e9f/go.mod h1:TdznJufoqS23FtqVCzL0ZqgP5MqXbb4fg/WgDys70nA= | ||
| github.com/btcsuite/btcutil v0.0.0-20190425235716-9e5f4b9a998d h1:yJzD/yFppdVCf6ApMkVy8cUxV0XrxdP9rVf6D87/Mng= | ||
| github.com/btcsuite/btcutil v0.0.0-20190425235716-9e5f4b9a998d/go.mod h1:+5NJ2+qvTyV9exUAL/rxXi3DcLg2Ts+ymUAY5y4NvMg= | ||
| github.com/btcsuite/btcutil v1.0.2 h1:9iZ1Terx9fMIOtq1VrwdqfsATL9MC2l8ZrUY6YZ2uts= |
There was a problem hiding this comment.
Do the prior ones go away with a go mod tidy?
| github.com/btcsuite/go-socks v0.0.0-20170105172521-4720035b7bfd | ||
| github.com/btcsuite/goleveldb v0.0.0-20160330041536-7834afc9e8cd | ||
| github.com/btcsuite/snappy-go v0.0.0-20151229074030-0bdef8d06723 // indirect | ||
| github.com/btcsuite/goleveldb v1.0.0 |
There was a problem hiding this comment.
Given modules exist now, do we still need to vendor goleveldb?
There was a problem hiding this comment.
Our fork looks to be a year or so behind mainline: https://github.com/syndtr/goleveldb
|
Yeah once this is merged in, I can modify which status checks we require for merges. |
|
Now on by default! |
|
@Roasbeef do you think you could remove the travis status check now that this has been merged? |
build: replace travis-ci with github actions.
build: update deps
build: clean linter warnings