Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tools to require certain engine-level inputs #120

Closed
droazen opened this issue Jan 15, 2015 · 3 comments
Closed

Allow tools to require certain engine-level inputs #120

droazen opened this issue Jan 15, 2015 · 3 comments
Assignees
@droazen
Labels
Documentation Engine enhancement

Comments

@droazen
Copy link
Contributor

droazen commented Jan 15, 2015

If a tool requires a reference, for example, it should be able to indicate so via an annotation, instead of manually checking the inherited argument value for null. The engine should perform the check on behalf of the tool.
@droazen droazen mentioned this issue Feb 5, 2015
Closed
@akiezun akiezun added this to the Coelacanth milestone Feb 26, 2015
@akiezun akiezun added the Doc label Feb 26, 2015
@droazen
Copy link
Contributor Author

droazen commented Feb 27, 2015

This will be done through overridable methods in my upcoming branch, rather than through annotations.

@droazen droazen self-assigned this Feb 27, 2015
@droazen droazen mentioned this issue Mar 12, 2015
Closed
@droazen
Copy link
Contributor Author

droazen commented Mar 12, 2015

Ended up punting on this in my latest branch in order to get IntervalWalker checked in, as it proved problematic/controversial. We'll need to iteratively try various approaches here to discover one that makes everyone happy. Related to #149

@droazen droazen changed the title Add annotations allowing tools to require certain engine-level inputs Allow tools to require certain engine-level inputs Mar 13, 2015
@droazen
Copy link
Contributor Author

droazen commented Mar 16, 2015

This was done as part of #297 -- closing.

@droazen droazen closed this as completed Mar 16, 2015
@akiezun akiezun modified the milestone: Coelacanth Apr 20, 2015
jamesemery added a commit that referenced this issue May 18, 2022
@jamesemery
fixed a very rare edge case in the adaptive chain pruner where the ja…
92f21bc 
…va priority queue is non-determinsitic (#120)
jamesemery added a commit that referenced this issue Jun 1, 2022
@jamesemery
fixed a very rare edge case in the adaptive chain pruner where the ja…
124d6d3 
…va priority queue is non-determinsitic (#120)
jamesemery added a commit that referenced this issue Jul 22, 2022
@jamesemery
fixed a very rare edge case in the adaptive chain pruner where the ja…
8cce72c 
…va priority queue is non-determinsitic (#120)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@droazen droazen

Labels
Documentation Engine enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@droazen @akiezun @davidbenjamin