Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Overriding inherited options #149

Closed
lbergelson opened this issue Jan 22, 2015 · 6 comments
Closed

Overriding inherited options #149

lbergelson opened this issue Jan 22, 2015 · 6 comments
Assignees
Milestone

Comments

@lbergelson
Copy link
Member

Tools be able to override the behavior of options they have inherited?

How should this work? Should you be able to change a required field to an optional one? Or only the other way around?

If you override the a field that has an @Option annotation does it effectively replace it?

@droazen
Copy link
Contributor

droazen commented Feb 27, 2015

Am going to address part of this ticket in my next branch by giving tools a way to indicate that particular data sources are required or optional, even when the inherited argument itself is marked as optional. Once this is done, all we probably need to do is change the code that displays the tool arguments to the user so that they take each tools requirements into account when displaying args.

@droazen
Copy link
Contributor

droazen commented Apr 6, 2015

Louis has a solution for this!

@akiezun
Copy link
Contributor

akiezun commented Apr 14, 2015

@lbergelson is this solution going in this iteration?

@akiezun
Copy link
Contributor

akiezun commented Apr 15, 2015

@lbergelson ping

@lbergelson
Copy link
Member Author

Oh, sorry, I missed that last comment. Yeah this should go in. It's been sitting in local branch, just need to update it.

@lbergelson
Copy link
Member Author

This is not resolved in the general case, but it is resolved in the case of the special BAM, reference, and interval options in walkers. Going to close this. Reopen when it comes up as an issue again.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants