Real-time Sync: Track latest address derivation index #579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hydra-yse
force-pushed
the
yse-rt-integrate
branch
from
46d6f06
to
00cdb98
Compare
hydra-yse
force-pushed
the
yse-rt-address
branch
from
449b37f
to
733c084
Compare
hydra-yse
force-pushed
the
yse-rt-integrate
branch
from
00cdb98
to
5903bc3
Compare
hydra-yse
force-pushed
the
yse-rt-address
branch
from
733c084
to
eedc673
Compare
hydra-yse
force-pushed
the
yse-rt-integrate
branch
from
5903bc3
to
08abf12
Compare
hydra-yse
force-pushed
the
yse-rt-address
branch
from
eedc673
to
84feca6
Compare
hydra-yse
force-pushed
the
yse-rt-address
branch
from
84feca6
to
e838e2a
Compare
dangeross
reviewed
Nov 27, 2024
| LAST_DERIVATION_INDEX_DATA_ID, | ||
| RecordType::LastDerivationIndex, | ||
| // insert a mock updated field so that merging with incoming data works as expected | ||
| Some(vec!["last-derivation-index".to_string()]), |
There was a problem hiding this comment.
Can you use LAST_DERIVATION_INDEX_DATA_ID here?
| @@ -105,6 +107,7 @@ impl Record { | |||
| SyncData::Chain(_) => "chain-swap", | |||
| SyncData::Send(_) => "send-swap", | |||
| SyncData::Receive(_) => "receive-swap", | |||
| SyncData::LastDerivationIndex(_) => "wallet-address", | |||
There was a problem hiding this comment.
Could we use derivation-index instead? wallet address doesn't seem right
| @@ -115,6 +118,7 @@ impl Record { | |||
| RecordType::Chain => "chain-swap", | |||
| RecordType::Send => "send-swap", | |||
| RecordType::Receive => "receive-swap", | |||
| RecordType::LastDerivationIndex => "wallet-address", | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #555, #556, #568, #578.