-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Real-time Sync: Add pull and merge #556
base: yse-rt-persist
Are you sure you want to change the base?
Conversation
fa9dd75
to
8b6a409
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The structure looks good and easy to review! There are some points we need to addres.
c2fbcc1
to
9862dc4
Compare
8b6a409
to
9a43ba8
Compare
9862dc4
to
cce9684
Compare
9a43ba8
to
ea5a5a6
Compare
ea5a5a6
to
9029a5d
Compare
7c1cfbc
to
f422c7a
Compare
9029a5d
to
ee0a2ba
Compare
84c7f96
to
0c56f34
Compare
2587800
to
9a63135
Compare
9a63135
to
37d6311
Compare
25e3d8e
to
d4d28dd
Compare
37d6311
to
8f983c6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A small comment regarding version parsing, otherwise shaping up really good and LGTM.
8f983c6
to
3ed46e0
Compare
d4d28dd
to
fc6cff2
Compare
3ed46e0
to
19f4ba3
Compare
fc6cff2
to
c2d2f82
Compare
19f4ba3
to
2e5069f
Compare
c2d2f82
to
8fce375
Compare
e97418e
to
4de369e
Compare
8fce375
to
656e042
Compare
4de369e
to
bd1f7ae
Compare
656e042
to
eb0400b
Compare
bd1f7ae
to
c3a5d6e
Compare
c3a5d6e
to
29c1565
Compare
eb0400b
to
be3091d
Compare
29c1565
to
8405996
Compare
Closes #502, closes #503.
Based on #555.