Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Real-time Sync: Add pull and merge #556

Open
wants to merge 8 commits into
base: yse-rt-persist
Choose a base branch
from
Open

Conversation

hydra-yse
Copy link
Collaborator

@hydra-yse hydra-yse commented Nov 10, 2024

Closes #502, closes #503.
Based on #555.

@hydra-yse hydra-yse self-assigned this Nov 10, 2024
@hydra-yse hydra-yse force-pushed the yse-rt-merge branch 3 times, most recently from fa9dd75 to 8b6a409 Compare November 10, 2024 23:30
@hydra-yse hydra-yse marked this pull request as ready for review November 10, 2024 23:40
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The structure looks good and easy to review! There are some points we need to addres.

lib/core/src/sync/client.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Show resolved Hide resolved
lib/core/src/persist/receive.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/sync/mod.rs Outdated Show resolved Hide resolved
lib/core/src/persist/sync.rs Outdated Show resolved Hide resolved
lib/core/src/persist/sync.rs Outdated Show resolved Hide resolved
@hydra-yse hydra-yse force-pushed the yse-rt-persist branch 2 times, most recently from 25e3d8e to d4d28dd Compare November 14, 2024 18:26
Copy link
Member

@roeierez roeierez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A small comment regarding version parsing, otherwise shaping up really good and LGTM.

lib/core/src/sync/model/mod.rs Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants