Real-time Sync: Add push logic and run method #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roeierez
requested changes
Nov 16, 2024
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
2e5069f
to
e97418e
Compare
hydra-yse
force-pushed
the
yse-rt-run
branch
from
ae6e68e
to
5069019
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
e97418e
to
4de369e
Compare
hydra-yse
force-pushed
the
yse-rt-run
branch
from
5069019
to
f87a697
Compare
roeierez
requested changes
Nov 18, 2024
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
4de369e
to
bd1f7ae
Compare
hydra-yse
force-pushed
the
yse-rt-run
branch
from
31adb31
to
902b6a9
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
bd1f7ae
to
c3a5d6e
Compare
hydra-yse
force-pushed
the
yse-rt-run
branch
3 times, most recently
from
61a24ee
to
ac5c4b3
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
c3a5d6e
to
29c1565
Compare
roeierez
reviewed
Nov 21, 2024
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
29c1565
to
8405996
Compare
hydra-yse
force-pushed
the
yse-rt-run
branch
from
ac5c4b3
to
dbd3736
Compare
hydra-yse
force-pushed
the
yse-rt-run
branch
2 times, most recently
from
ca96325
to
f024c00
Compare
hydra-yse
force-pushed
the
yse-rt-run
branch
from
f024c00
to
741ec9a
Compare
dangeross
reviewed
Nov 28, 2024
lib/core/src/persist/receive.rs
Outdated
| @@ -316,6 +324,11 @@ impl Persister { | |||
| }, | |||
| )?; | |||
|
|
|||
| let updated_fields = get_updated_fields!(mrh_tx_id, mrh_amount_sat); | |||
There was a problem hiding this comment.
Both these fields are recovered in the sync, so is this needed?
There was a problem hiding this comment.
No, not anymore 👍
| } | ||
| } | ||
|
|
||
| pub(crate) async fn run(self: Arc<Self>, mut shutdown: watch::Receiver<()>) -> Result<()> { |
There was a problem hiding this comment.
Shall we call it start() for consistency?
There was a problem hiding this comment.
Handled in next PR (#578)
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
8405996
to
493b38d
Compare
hydra-yse
force-pushed
the
yse-rt-run
branch
from
741ec9a
to
e9f9798
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
493b38d
to
073d515
Compare
hydra-yse
force-pushed
the
yse-rt-run
branch
from
e9f9798
to
8714645
Compare
hydra-yse
force-pushed
the
yse-rt-merge
branch
from
073d515
to
ce601d9
Compare
hydra-yse
force-pushed
the
yse-rt-run
branch
from
8714645
to
4e4b73f
Compare
dangeross
reviewed
Nov 29, 2024
|
|
||
| // Clean incoming | ||
| let record = Record::new( | ||
| SyncData::Receive(new_receive_sync_data(None, None)), |
There was a problem hiding this comment.
Suggested change
| SyncData::Receive(new_receive_sync_data(None, None)), | |
| SyncData::Receive(new_receive_sync_data()), |
| assert_eq!(incoming_records.len(), 0); // Records have been cleaned | ||
|
|
||
| let mut inapplicable_record = Record::new( | ||
| SyncData::Receive(new_receive_sync_data(None, None)), |
There was a problem hiding this comment.
Suggested change
| SyncData::Receive(new_receive_sync_data(None, None)), | |
| SyncData::Receive(new_receive_sync_data()), |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #555 and #556.
Closes #504, closes #505.
TODO: