Ext mouse buttons #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add Gradle wrapper files. Relates to javafxports#23
…-build-media 8200277: Compiling native media code fails when using OpenJDK build as boot JDK
… to build (javafxports#49) 1. Added the gradle.md license file 2. Replaced gradle-wrapper.jar with one generated from gradle 4.3 to match the version in the license file (we shouldn't need to update this again after this) With the above changes, there should be no merge conflicts when JDK-8199841 is integrated to the upstream openjfx/jfx-dev repo.
Gradle build failure should show informative message
* Update CONTRIBUTING documentation to make use of gradle wrapper
* Provide an infrastruture to supply custom toolchain paths to FX build system
brcolow
force-pushed
the
ext-mouse-buttons
branch
from
3bd9b0d to
a527689
Compare
Platform native windows (for Windows, macOS, and Linux) are adapted to listen for BACK/FORWARD mouse button activity and fire respective MouseEvents, as is currently done for PRIMARY, MIDDLE, and RIGHT. We also add support for emulating mouse button press/release with BACK/FORWARD to the native robot implementations so that e.g. Robot#mousePress(MouseButton.BACK) will work as intended on Windows, macOS, and Linux. This new functionality is tested in an integrated way by adding two tests to test/robot/javafx/scene/RobotTest.java that firstly use the Robot to press and release the BACK/FORWARD buttons on a scene-graph Node and then secondly ensure that the onMouseClicked event listener properly fires a MOUSE_CLICKED event for the respective BACK/FORWARD button. This ensures that the new mouse buttons are supported not only on the Java side, but on the native side as well.
brcolow
force-pushed
the
ext-mouse-buttons
branch
from
a527689 to
b6270b4
Compare
brcolow
force-pushed
the
ext-mouse-buttons
branch
from
bc282e9 to
315551a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.