This repository has been archived by the owner on Jun 24, 2021. It is now read-only.
8200277: Compiling native media code fails when using OpenJDK build as boot JDK #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@johanvos please review when you get a spare moment... |
|
Looks good, and CI passed. |
|
There are gradle bugs that prevent using JDK 11: gradle/gradle#4515 (fixed in gradle-4.7 EA) |
|
OpenJDK 10 GA (fcs) is what I use. |
|
I rebased my changeset on top of the latest develop branch. |
|
I can confirm this patch fixes https://bugs.openjdk.java.net/browse/JDK-8200277 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a fix for JDK-8200277 which in turn is a stopper for separating JavaFX from the JDK.
Once this is merged into the develop branch of openjfx-jdk I will send the review request on the openjfx-dev mailing list.