Skip to content
This repository has been archived by the owner on Jun 24, 2021. It is now read-only.

Add gradle wrapper files #23

Closed
aalmiray opened this issue Mar 15, 2018 · 13 comments
Closed

Add gradle wrapper files #23

aalmiray opened this issue Mar 15, 2018 · 13 comments

Comments

@aalmiray
Copy link
Contributor

The build (currently) has a strict check on Gradle 4.3 as supported version. It's recommended to use the Gradle wrapper to ensure a project is built with the correct Gradle version for it.

Consider adding gradle wrapper files.

@johanvos
Copy link
Collaborator

I'm in favor of this too. There was some discussion previously where people argued against it, but I forgot the reasons.

@hendrikebbers
Copy link

hendrikebbers commented Mar 17, 2018 via email

@eugener
Copy link
Collaborator

eugener commented Mar 19, 2018

+1. But before merging, both builds at TravisCI and AppVeyor should be fixed/tested.

@johanvos
Copy link
Collaborator

Can you create an issue in JBS and refer to here?

@aalmiray
Copy link
Contributor Author

Sure, I can, one question though: what's JBS?

@johanvos
Copy link
Collaborator

:) Java Bug System, see
https://github.com/javafxports/openjdk-jfx/blob/develop/.github/CONTRIBUTING.md

I am very well aware of the double administration of this, but in order to have patches that can go upstream, this is an important step.

@aalmiray
Copy link
Contributor Author

Done. internal review ID : 9053024

@hendrikebbers
Copy link

Just one question: Why do we use Travis AND AppVeyor? Shouldn't one CI build be enough?

@aalmiray
Copy link
Contributor Author

Appveyor runs on Windows while Travis runs on Linux by default.

@hendrikebbers
Copy link

ah, THX :)

@aalmiray
Copy link
Contributor Author

@johanvos
Copy link
Collaborator

covered by PR #26 which can be merges as soon as builds are successful.

johanvos added a commit that referenced this issue Mar 23, 2018
Add Gradle wrapper files. Relates to #23
@johanvos
Copy link
Collaborator

builds passed (against develop branch), PR merged

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants