-
Notifications
You must be signed in to change notification settings - Fork 146
Add gradle wrapper files #23
Comments
I'm in favor of this too. There was some discussion previously where people argued against it, but I forgot the reasons. |
+1
Von meinem iPhone gesendet
… Am 15.03.2018 um 15:13 schrieb Andres Almiray ***@***.***>:
The build (currently) has a strict check on Gradle 4.3 as supported version. It's recommended to use the Gradle wrapper to ensure a project is built with the correct Gradle version for it.
Consider adding gradle wrapper files.
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
+1. But before merging, both builds at TravisCI and AppVeyor should be fixed/tested. |
Can you create an issue in JBS and refer to here? |
Sure, I can, one question though: what's JBS? |
:) Java Bug System, see I am very well aware of the double administration of this, but in order to have patches that can go upstream, this is an important step. |
Done. internal review ID : 9053024 |
Just one question: Why do we use Travis AND AppVeyor? Shouldn't one CI build be enough? |
Appveyor runs on Windows while Travis runs on Linux by default. |
ah, THX :) |
covered by PR #26 which can be merges as soon as builds are successful. |
Add Gradle wrapper files. Relates to #23
builds passed (against develop branch), PR merged |
The build (currently) has a strict check on Gradle 4.3 as supported version. It's recommended to use the Gradle wrapper to ensure a project is built with the correct Gradle version for it.
Consider adding gradle wrapper files.
The text was updated successfully, but these errors were encountered: