Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Allow user to add and edit custom search engines #3053

Closed
dawikur opened this issue Aug 9, 2016 · 45 comments
Closed

Allow user to add and edit custom search engines #3053

dawikur opened this issue Aug 9, 2016 · 45 comments
Labels
feature/search fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. needs-mockup A feature which needs design mockup to be implemented. wontfix

Comments

@dawikur
Copy link

dawikur commented Aug 9, 2016

Did you search for similar issues before submitting this one?
Yep, unfortunately didn't found one.

Describe the issue you encountered:
I use Chrome search engine to make fast searched not only in google/duckduckgo/etc but
also e.g. cpp references, like:
cpp? vector
takes me to

http://en.cppreference.com/mwiki/index.php?title=Special%3ASearch&search=vector

I have a lot of shorts like this, for translation, google maps, etc. It would be great to use similar mechanism (as I am quite addicted to it) for brave

Expected behavior:
In the Search settings page we can put 'add' button, similar as it is in chrome

searchengines

  • Platform (Win7, 8, 10? macOS? Linux distro?):
    All of them, please.
  • Brave Version:
    0.11.3
  • Any related issues:
    All that asks for new search engine.
@bradleyrichter bradleyrichter added this to the 1.1.0 milestone Aug 9, 2016
@bradleyrichter
Copy link
Contributor

@dawikur Thanks for the request. We have this planned for the 1.1 timeframe, starting with a sub-task to allow editing of the engine paths.

@anaelChardan
Copy link

+1 :) I want to use Qwant as search engine :)

@da2x
Copy link
Contributor

da2x commented Sep 3, 2016

All search engines, and then I mean every single one of them, have OpenSearch auto-discovery on their home pages and search result pages. Safari and Edge automatically detects OpenSearch-enabled search engines and lists them as suggested search engines in their Preference panes.

This means that every user will find their favorite search engine in the list of possible search engines without having to configure it; they just need to perform one search with their favorite engine and it will then become available. I wrote about this on my blog for anyone interested in the specifics.

I think this is an elegant solution that empowers even inexperienced users to change their search engine to whichever they prefer without technical knowledge. It also exposes many more possible search engines than a browser could reasonably build-in by default. The approach sounds like a good fit for Brave.

@bridiver
Copy link
Collaborator

related #4210

@RasmusMalver
Copy link

RasmusMalver commented Jan 30, 2017

Can we expand this issue / feature-request / enhancement to also cover “editing and deleting the included search engines”?

Like peterjohn on brave.com I use websites in different languages with different keywords. Eg. wde (de.wikipedia.org), wfr (fr.wikipedia.org), a (amazon.co.uk), ade (amazon.de) etc.

But in Brave the american versions are preloaded and cannot be changed.

Also; searching the internet in different languages requires a lot of tweaking in the search queries.

Eg. a non-country specific verbatim Google search query for brave browser:

https://www.google.com/webhp?gfe_rd=cr&gws_rd=cr&fg=1#q=brave+browser&tbs=li:1

It'd be nice to be able to define ones own queries, like in most other browsers, rather than depending on the developers to choose their faves.

@bsclifton
Copy link
Member

per #2850, we should be able to edit the "go keywords" for search engines added

@crysman
Copy link

crysman commented Mar 20, 2017

This is really missing... it's a pain to work without this functionality. Thank you for having this already planned to implement.

@basilweibel
Copy link

1+; only feature missing to make me switch from Chrome. Keep up the great work!

@hanswundersam
Copy link

Hi @bradleyrichter, last summer you mentioned this feature would be available "for the 1.1 timeframe". Now we're at version 0.15.3. Is it possible to estimate when 1.1 is expected to come out? Just so that people know how long they will have to wait. Thank you!

@ghost
Copy link

ghost commented May 26, 2017

Since it seems that 1.1 is going to be awhile down the road, may I ask for these sites to be added. Since that seems to be the only possibility. Literally just going to add things to this post.

http://www.dogpile.com/
http://boardreader.com/
http://www.ask.com/
http://www.lycos.com/
http://www.excite.com/
http://www.entireweb.com/
https://search.creativecommons.org/
https://giphy.com/
https://vimeo.com/
https://www.reddit.com/
https://twitter.com/search-home
https://plays.tv/home
http://www.crunchyroll.com/
https://www.hulu.com/
https://www.twitch.tv/
https://www.slant.co/

https://www.dotdash.com/our-brands/ ~About.com split into multiple sites
https://vrv.co/ ~looks promising, similar to Netflix?

Bonus points
https://www.4chan.org/ and the ability to switch between which board you want to look at.

@srirambv
Copy link
Collaborator

srirambv commented Jun 7, 2017

+1 for discogs.com from community https://community.brave.com/t/engine-go-key-for-discogs-com/3601

@Chen-pan
Copy link

+1 and edit search engine address 👍

@Ornataweaver
Copy link

#790 #824 #3053 #3294 #4210

@xaggaz
Copy link

xaggaz commented Oct 28, 2017

+1 for this feature.
I use metager.de, please consider adding it to the default list (since it can help it's adoption). Although the design is not super, it is open source, focused on privacy and data protection and so far it has provided me better results than DuckDuckGo, it is closer to Google accuracy. MetaGer is made in Germany but it has just added support for English language (I use it in English). Nevertheless, according to Wikipedia there are ~100 Million German speaking people (82M Germany, 9M Austria and 8M Switzerland). Thanks!

@joshuadanpeterson
Copy link

The moment OpenSearch is integrated into Brave is the moment Brave becomes my default browser for good. Just wanted to put that out there.

@alexwykoff alexwykoff modified the milestones: 1.1.0, Backlog Nov 1, 2017
@Ornataweaver
Copy link

Ornataweaver commented Nov 1, 2017

Plus Stylish. I have put Brave aside for now.

@kartikthapar
Copy link

We use BunnyLol here at Facebook and without the custom search engine, Brave is basically unusable. This is not tracked in 1.1 anymore. Is this happening at all?

@benjibee
Copy link

I have 10+ custom searches setup in Chrome, I'm mostly using Brave now except when doing work that requires these search engines. What's the status of this? @bsclifton

@robomac
Copy link

robomac commented Dec 31, 2017

I'm in the same state as benjibee... Brave falls too far short without allowing me to customize my own search engines.

Consider this: By default, if you search for a random phrase, you often get hits 10+ years ago. So I set up in Chrome a set of searches that are date-limited. Saves a LOT of time. And I did this also for my partner on her laptop. She's not very web-savvy, but she wouldn't want to give that up.

And yet you won't let her have it.

What you guys don't seem to realize is, you need the influencers. We bring the tools to the rest of the world. And the request is currently 16 months old. Maybe there's a reason Brave isn't even cracking the lists yet.

I give up.

@benjibee
Copy link

@robomac I actually never thought of date-limited searches. That's brilliant for articles and tutorials for frameworks and languages that become outdated quickly. Thanks for the (non-Brave related) tip!

@crysman
Copy link

crysman commented Jan 2, 2018

I'm glad more and more people are requesting this important feature... Maybe someone will consider implementing it soon (?) I unfortunately cannot, since my programming skills are not high enough :/

@george-carlin
Copy link

This is by far the feature I miss the most from Chrome. I have dozens of these "search shortcuts" in Chrome that I've built up slowly over the last decade; they're etched into my muscle memory and it's a PITA to not have them.

Here's one example: I speak multiple languages and I frequently need to look up the English translation of a foreign word (or visa versa), so I have keywords set up in Chrome to search a bilingual dictionary (usually WordReference.com). So e.g. enes brave searches WR's English-Spanish for "brave", and espt valiente searches the Spanish-Portuguese dictionary for "valiente", etc..

Like others I also use these keywords for searching sites in different languages, e.g I have wiki for the English Wikipedia, but wifr for the French version, wies for the Spanish etc.. As it is, you can only use the Brave address bar to search the English version of the listed search engines, which clearly isn't what a lot of people will want.

I'm not familiar with OpenSearch but bear in mind that it's not just search engines that people will want to attach to a keyword. Zillions of websites have a "search this site" feature even though the site itself isn't Google or Yahoo. The proliferation of suggestions in this thread shows that it's simply not practical to have a single list of search engines that ships with Brave by default and isn't customisable.... especially when you consider that the early adopters of Brave are overwhelmingly going to be nerdy power users who like tinkering with and customising these kind of settings.

Also note Chrome actually adds these custom search keywords by default every time you search a new site. E.g. if I go to example.com and use its "search this site" feature (assuming it has one), Chrome will usually figure out that this is a search, and add example.com to my list of search "engines". Then the next time I type example.com into the address bar I'll see the option to search the site directly, like on the right here:

screen shot 2018-01-03 at 10 07 40

This is a handy default for the less technical user who doesn't think of adding these things manually. For people who like more customisation, it's now merely a matter of finding example.com in your search settings and changing the keyword from example.com to something more succinct like ex.

@benjibee
Copy link

benjibee commented Jan 4, 2018

@georgemillo I use it for exactly the same thing, enes, ende, etc. using WordReference.com!

That being said I don't think it should follow Chrome's behaviour of adding search engines to the custom list just by using them. I have my custom searches (which are very easy to add) and there's 100+ other sites I've used once or twice mixed in there, cluttering it up. If this is going to be implemented please don't auto-add anything 🙏

Perhaps that little tooltip in the address bar could ask to add them, like Press tab to add this search engine to your custom list

@george-carlin
Copy link

I have my custom searches (which are very easy to add) and there's 100+ other sites I've used once or twice mixed in there, cluttering it up. If this is going to be implemented please don't auto-add anything

Yeah, I have the same problem come to think of it - the auto-added searches clutter up my search settings. I still think some kind of auto-adding is a good idea though. Bear in mind most people aren't techies who comment on GitHub issues or tweak their custom search engines with fine precision. I'd bet most Chrome users don't even know that the keywords for your custom search engines can be customised.

Maybe "auto-add search engines when one is detected" could be a setting that's enabled by default?

Of course, this is all just details and isn't essential for a version 1.0 of this feature.

@george-carlin
Copy link

Another gripe: the inbuilt :a Amazon keyword only lets me search Amazon.com. No use to me as I use Amazon.co.uk.

@doomlaser
Copy link

I want to be able to make me own search shortcuts, and I don't want to have to type a : colon before every search shortcut. Why can't I just type ^space t whatever, to invoke a twitter search, instead of having to also make two key presses to input a redudant colon prefix?

Why can't Brave just import the custom search engine settings from Chrome, Firefox, or Safari and have the address bar behavior for custom search invocations be the same? It ould be much faster and more convenient.

@thiagola92
Copy link

thiagola92 commented Jan 19, 2018

My only problem is unable to uncheck search engines, i don't want to search on amazon.com by default.
uncheck this

EDIT: Okay, i am dumb.
When i first look i though that was like a checkbox (html input type). Now i understand that is just telling me that this is my default search engine when writing on address bar.
my mistake

@sly7-7
Copy link

sly7-7 commented Feb 21, 2018

Not sure if this the right place to ask, but would it be possible to add https://www.lilo.org/en/ as a search engine ?

@mehmetkz61
Copy link

+1 for this feature. It also would be great to have a remove option.

@kartikthapar
Copy link

Would love for this to be prioritized if possible. Most of my office work uses bunnylol and I just cannot use Brave for my needs because of this.

@dngen
Copy link

dngen commented Apr 11, 2018

+1

@immanuelfodor
Copy link

+1, I need the custom search engine settings so much, both Brave desktop and Android lacks this feature 😞

@vector623
Copy link

It looks like they are overhauling the frontend soon, which should address this issue: https://www.brave.com/development-plans-for-upcoming-release/

@cyboman
Copy link

cyboman commented Jul 9, 2018

This is one of the key features keeping me in Chrome. I've tried (again and again) to go back to Safari, Firefox, and now Brave, but my repeated, daily access of about a dozen sites is made much better with search engine keywords in Chrome.

@bsclifton bsclifton added wontfix fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. labels Jul 10, 2018
@bsclifton bsclifton removed this from the Triage Backlog milestone Jul 10, 2018
@bsclifton
Copy link
Member

bsclifton commented Jul 10, 2018

Given the requirements for this, we won't be able to fix this with browser-laptop so I'm going to close as wontfix.

However, we are moving to brave-core, a Chromium based UI which replaces the current Muon codebase. In brave-core, I have verified this is fixed! 😄 Here's a screenshot from Brave Core:

screen shot 2018-07-10 at 11 05 42 am

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
feature/search fixed-with-brave-core This issue will automatically resolved with the replacement of Muon with Brave Core. needs-mockup A feature which needs design mockup to be implemented. wontfix
Projects
None yet
Development

No branches or pull requests