Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add urban dictionary as a search engine / shortcut #3408

Closed
bsclifton opened this issue Aug 25, 2016 · 5 comments
Closed

Add urban dictionary as a search engine / shortcut #3408

bsclifton opened this issue Aug 25, 2016 · 5 comments

Comments

@bsclifton
Copy link
Member

Similar to our existing search engine list and shortcuts, it would be great to add support for Urban Dictionary

Proposed shortcut could be 'ud'

Search URL would be:
https://www.urbandictionary.com/define.php?term={searchTerm}

@bbondy
Copy link
Member

bbondy commented Aug 25, 2016

I don't have objections but just passing by some more people in case there's a problem I'm not thinking of. We should get in some normal dictionaries too though first.

@bradleyrichter @BrendanEich

@bradleyrichter
Copy link
Contributor

We block UD on our kids devices. I think auto-complete based on UD match could be a big problem?

@bsclifton
Copy link
Member Author

bsclifton commented Aug 27, 2016

Actually, that is a great point @bradleyrichter 😄

Maybe a better solution would be to allow for user-customizable search engines. If we add them to Brave, it's like we're indirectly endorsing it. But it would be great to allow people to add more at their convenience

If that makes more sense, I can update this ticket to capture information about that

@bradleyrichter
Copy link
Contributor

@bsclifton We need 2 new issues.

  1. add the ability to edit the URL of the default engine list. (ala chrome)
  2. Allow adding your own engine.

The UI will support both in terms of space but needs to be detailed out.

@bsclifton bsclifton changed the title Add urban dictionary as a search engine / shortcut Allow users to add their own search engines (including shortcut) in preferences Aug 27, 2016
@bsclifton bsclifton changed the title Allow users to add their own search engines (including shortcut) in preferences Add urban dictionary as a search engine / shortcut Aug 27, 2016
@bsclifton
Copy link
Member Author

case 1 might be covered by #1103
case 2 is covered by #3053

Closing this issue 😄

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants