Skip to content
This repository has been archived by the owner on Dec 11, 2019. It is now read-only.

Add Yandex to search engine prefs and results #2703

Closed
bradleyrichter opened this issue Jul 25, 2016 · 8 comments
Closed

Add Yandex to search engine prefs and results #2703

bradleyrichter opened this issue Jul 25, 2016 · 8 comments
Assignees
@bsclifton
Labels
feature/search QA/checked-Linux QA/checked-Win32 QA/checked-Win64 settings
Milestone
0.12.15

Comments

@bradleyrichter
Copy link
Contributor

Yandex offers an API that will integrate deeper into search results by providing suggestions from Yandex in real time.

image

Yandex API info for POST requests:

https://tech.yandex.com/xml/doc/dg/concepts/post-request-docpage/

API keys are private.
@bradleyrichter bradleyrichter added this to the 1.0.0 milestone Jul 25, 2016
@bbondy bbondy mentioned this issue Jul 25, 2016
Closed
@bsclifton bsclifton self-assigned this Aug 24, 2016
@bbondy bbondy assigned jkup and unassigned bsclifton and darkdh Aug 29, 2016
@luixxiul luixxiul mentioned this issue Nov 16, 2016
Closed
@bsclifton bsclifton self-assigned this Nov 22, 2016
@bsclifton bsclifton modified the milestones: 0.13.0, 1.0.0 Nov 22, 2016
@bsclifton
Copy link
Member

bsclifton commented Nov 30, 2016 •
edited
Loading

Per @aekeus's comment on Slack, this will need a fix to be able to handle POST:
https://github.com/brave/browser-laptop/blob/master/js/components/urlBarSuggestions.js#L431

@cndouglas
Copy link

Handling POST would also help #5235.

@bsclifton bsclifton mentioned this issue Dec 1, 2016
Closed
@bsclifton
Copy link
Member

I've implemented general search and confirmed it's working well. I created a separate issue for tracking search suggestions by Yandex which can be found here: #5963

@bsclifton bsclifton mentioned this issue Dec 1, 2016
Merged
4 tasks
bbondy pushed a commit that referenced this issue Dec 13, 2016
@bsclifton @bbondy
Add Yandex.com as a search engine
863e0ff 
Fixes #2703

Also includes
- small refactor in js/components/urlBar.js which should make future changes easier (and opens this up to unit testing)
- removes permafail webdriver test that should have been removed with #5826 (I missed the fact CI failed on this when reviewing)

Auditors: @bbondy, @cezaraugusto

Test Plan:
1. Launch Brave and open Preferences
2. Set Yandex as your default search engine
3. Search in the omnibox, confirm it shows results on yandex.com
4. Check the URL that was created; client ID (clid=) should be:
  - 2274777 on Windows
  - 2274776 on macOS
  - 2274778 on linux
5. Try the search engine shortcut, :ya and do a search in the omnibox
@bbondy bbondy modified the milestones: 0.12.15, 0.13.0 Dec 13, 2016
This was referenced Dec 13, 2016
Closed
Closed
Closed
Closed
@htmathias
Copy link

Where's Ecosia?

It was listed as number 3 here.

@luixxiul
Copy link
Contributor

luixxiul commented Feb 2, 2017

I think it is just a suggestion and not decided to include it

@cndouglas
Copy link

Regardless, custom search engines (#3053—1.1.0 milestone) will solve the problem.

@luixxiul
Copy link
Contributor

luixxiul commented Feb 2, 2017

Exactly!

@cndouglas cndouglas mentioned this issue Feb 10, 2017
Closed
@cndouglas
Copy link

I posted a separate issue for Ecosia at #7158.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@bsclifton bsclifton

Labels
feature/search QA/checked-Linux QA/checked-Win32 QA/checked-Win64 settings
Projects
None yet
Milestone
0.12.15
Development

No branches or pull requests
9 participants
@jkup @bbondy @luixxiul @bsclifton @htmathias @darkdh @bradleyrichter @srirambv @cndouglas