This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #856: Add Rate Brave option in settings #873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BraveShared/BraveStrings.swift
Outdated
| @@ -455,6 +455,7 @@ public extension Strings { | |||
| public static let Never_show = NSLocalizedString("NeverShow", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Never show", comment: "tabs bar show/hide option") | |||
| public static let Always_show = NSLocalizedString("AlwaysShow", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Always show", comment: "tabs bar show/hide option") | |||
| public static let Show_in_landscape_only = NSLocalizedString("ShowInLandscapeOnly", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Show in landscape only", comment: "tabs bar show/hide option") | |||
| public static let Review_Brave = NSLocalizedString("ReviewBrave", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Review Brave", comment: "Open the App Store to write a review for Brave.") | |||
There was a problem hiding this comment.
@jamesmudgett can you approve the copy and the design.
|
Really nice @liunkae just confirming some things on our end, and we'll get this in. |
|
@liunkae Really nice, just talked with design, and they wanted to make the following changes:
|
cndouglas
changed the title
|
@jhreis Done. |
jhreis
approved these changes
Mar 5, 2019
14 tasks
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #856
Per "Manually Request a Review" in the "Requesting App Store Reviews" documentation:
This change adds the Rate Brave option in settings. When Rate Brave is tapped, the App Store is opened with a screen to rate Brave.
Submitter Checklist:
Fix #123: This fixes the shattered coffee cup!(orNo Bug: <message>if no relevant ticket)NSLocalizableString()Test Plan:
Screenshots:
Settings option:
Reviewer Checklist:
QA/(Yes|No)release-notes/(include|exclude)bug/enhancement