Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #856: Add Rate Brave option in settings #873

Merged
merged 1 commit into from
Mar 5, 2019
Merged

Fix #856: Add Rate Brave option in settings #873

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions BraveShared/BraveStrings.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -455,6 +455,7 @@ public extension Strings {
public static let Never_show = NSLocalizedString("NeverShow", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Never show", comment: "tabs bar show/hide option")
public static let Always_show = NSLocalizedString("AlwaysShow", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Always show", comment: "tabs bar show/hide option")
public static let Show_in_landscape_only = NSLocalizedString("ShowInLandscapeOnly", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Show in landscape only", comment: "tabs bar show/hide option")
public static let Rate_Brave = NSLocalizedString("RateBrave", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Rate Brave", comment: "Open the App Store to rate Brave.")
public static let Report_a_bug = NSLocalizedString("ReportABug", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Report a bug", comment: "Show mail composer to report a bug.")
public static let Privacy_Policy = NSLocalizedString("PrivacyPolicy", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Privacy Policy", comment: "Show Brave Browser Privacy Policy page from the Privacy section in the settings.")
public static let Terms_of_Use = NSLocalizedString("TermsOfUse", tableName: "BraveShared", bundle: Bundle.braveShared, value: "Terms of Use", comment: "Show Brave Browser TOS page from the Privacy section in the settings.")
Expand Down
9 changes: 9 additions & 0 deletions Client/Frontend/Settings/SettingsViewController.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -320,6 +320,15 @@ class SettingsViewController: TableViewController {
self.dismiss(animated: true)
},
cellClass: MultilineButtonCell.self),
Row(text: Strings.Rate_Brave,
selection: { [unowned self] in
// Rate Brave
guard let writeReviewURL = URL(string: "https://geo.itunes.apple.com/app/id1052879175?action=write-review")
else { return }
UIApplication.shared.open(writeReviewURL)
self.dismiss(animated: true)
},
cellClass: MultilineValue1Cell.self),
Row(text: Strings.Privacy_Policy,
selection: { [unowned self] in
// Show privacy policy
Expand Down