Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Add "Review Brave" Option in Settings #856

Closed
jhreis opened this issue Feb 5, 2019 · 9 comments · Fixed by #873
Closed

Add "Review Brave" Option in Settings #856

jhreis opened this issue Feb 5, 2019 · 9 comments · Fixed by #873

Comments

@jhreis
Copy link
Contributor

jhreis commented Feb 5, 2019

Description:

Add a "Review Brave" option in settings that utilizes SKStoreReviewController and presents a review prompt to the user.

This should go above "Report a bug" under the "Support" column.

@LaurenWags
Copy link
Member

When I tap on 'Rate Brave', Safari opens and then I get a popup that says 'Open in "App Store"?'. Is this expected?

IMG_E6B32A03BB8B-1

@cndouglas
Copy link
Contributor

@LaurenWags No, it should go directly to the App Store.

Looks like the deep link URL is incorrect. I'll fix it.

@LaurenWags
Copy link
Member

thanks @liunkae - reopening this issue.

@cndouglas
Copy link
Contributor

URL fixed by this PR: #972

@srirambv
Copy link
Contributor

srirambv commented Mar 18, 2019

  • Verification passed on iPad Pro/iPhone 6/iPhone 7+ running 1.9(19.3.9.1) for the option being available in setting.
  • Verified passed with 1.9 (19.3.9.1) on iPhone SE. Reproduced Fix #989: Fix Rate Brave URL added in 30dd20e #972.
  • Verification PASSED with 1.9 (19.03.25.21) on iPad Mini 4 using the above STR.

@LaurenWags could you please log a new issue for #856 (comment) which @liunkae can refer it in #972

@LaurenWags
Copy link
Member

@srirambv logged #989

@kjozwiak
Copy link
Member

This should go above "Report a bug" under the "Support" column.

Noticed that the Rate Brave menu item is BELOW Report a bug and not ABOVE it. @jhreis is this an issue? From the sounds of the original comment, it should be the first item under Support. Example using 1.9 (19.03.25.21):

IMG_1A6862C635E9-1

CCing @srirambv

@cndouglas
Copy link
Contributor

@kjozwiak See @jhreis's comment: #873 (comment)

@kjozwiak
Copy link
Member

@liunkae perfect 👍 Much appreciated.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants