This repository has been archived by the owner on May 10, 2024. It is now read-only.
Fix #7448, fix #7413: VPN Initialize and Connect issues #7525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soner-yuksel
force-pushed
the
fix/vpn-issue-cleanup
branch
from
590eaca to
bd15c97
Compare
iccub
changed the title
iccub
force-pushed
the
fix/vpn-issue-cleanup
branch
from
bd15c97 to
524aa07
Compare
adityarajpt
reviewed
Jun 2, 2023
| // Retry installing profile twice if it fails | ||
| // Error generated is WireGuard capabilities are not yet enabled on this node | ||
| if self.installVPNProfileRetryCount < 2 { | ||
| installVPNAction() |
There was a problem hiding this comment.
self.installVPNAction()
arthuredelstein
pushed a commit
to brave/brave-core
that referenced
this pull request
Feb 13, 2024
…d Connect issues (brave/brave-ios#7525)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request fixes the problem with infinite loading indicator when connection is successful. In addition it is adding a proper loading to Install profile and buy vpn screens, to handle problem with Profile install, it is added a retry mechanism to silently try to connect again since the tests how additional try will always succeed for install.
Summary of Changes
This pull request fixes #7448
This pull request fixes #7413
Submitter Checklist:
NSLocalizableString()Test Plan:
7448
Launch Brave > Three Dot Menu
Enable VPN
Don't close the panel > Observe
7413
Install 1.51.x, 1.50.x
Complete IAP (Sandbox)
Install VPN Profile
Observe
Screenshots:
7448
RPReplay_Final1685127563.MP4
7413
RPReplay_Final1685127676.MP4
Reviewer Checklist:
QA/(Yes|No)bug/enhancement