Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[Follow up to #7432] An Infinite loading spinner is shown next to toggle switch when enabling VPN #7448

Closed
hffvld opened this issue May 12, 2023 · 4 comments · Fixed by #7525

Comments

@hffvld
Copy link
Collaborator

hffvld commented May 12, 2023

Description:

Follow-up to #7432

Steps to Reproduce

  1. Launch Brave > Three Dot Menu
  2. Enable VPN
  3. Don't close the panel > Observe

Actual result:

An infinite loading spinner is shown next to the toggle switch when enabling VPN via the pop-up menu. If you close and reopen that menu, the loading spinner is not there anymore.

NOTE: This issue is not reproducible with 1.52

VPN_Infinite.spinner.mov

Expected result:

When enabling VPN, infinite loading spinner must not be shown

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes, with the latest 1.51
  • Can you reproduce this issue with the previous version of the current build from TestFlight? Yes
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone 14 [iOS 16.4.1]

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

@soner-yuksel
Copy link
Contributor

@vlad-hoff I cant reproduce this, did you try reproducing it with latest 1.51 (23..5.11.22)

@soner-yuksel
Copy link
Contributor

@vlad-hoff I retested using 2 devices both latest 1.51 an d 1.52. Both is not having this particular problem. Please can you take a look again.
cc @iccub Can you also try when you have a chance ?

@hffvld
Copy link
Collaborator Author

hffvld commented May 23, 2023

Hi @soner-yuksel I'm sorry for the delayed reply. I just tried to install the latest 1.51.1 (23.5.19.19) build, and the issue is still reproducible.

VPN_Spinner.mov

@hffvld
Copy link
Collaborator Author

hffvld commented Jun 15, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.5]
Version 1.52 (23.6.14.13)
BraveCore 1.52.125 (114.0.5735.110)

Filed follow-up issue #7606


STEPS:

  1. Launch Brave > Three-dot Menu > Brave VPN
  2. Purchase VPN (for TF) and install certificate
  3. Three-dot Menu > Enable/Disable Brave VPN > Verify

ACTUAL RESULTS:

  • Verified that enabling or disabling Brave VPN from the main menu is not showing infinite loading spinner anymore
  • Verified that the same infinite loading spinner is not shown when enabling/disabling VPN from Brave Firewall + VPN menu
VPN_Spinner.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.