Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Enable cookie consent notice blocking by default #7882

Closed
cuba opened this issue Aug 16, 2023 · 2 comments · Fixed by #7883
Closed

Enable cookie consent notice blocking by default #7882

cuba opened this issue Aug 16, 2023 · 2 comments · Fixed by #7883

Comments

@cuba
Copy link
Contributor

cuba commented Aug 16, 2023

Description:

We want to now enable this by default

Steps to Reproduce

  1. Install the app from scratch
  2. Check that cookie consent notice blocking is enabled
  3. Test cookie consent notice blocking works (will need to wait a few minutes as the necessary files download)
@iccub
Copy link
Contributor

iccub commented Aug 16, 2023

Are we not adding an opt-out popup?

See #7792

@soner-yuksel soner-yuksel added this to the 1.57 milestone Aug 16, 2023
cuba added a commit that referenced this issue Aug 16, 2023
* Enable cookie consent notice blocking by default

* Fix tests
@hffvld
Copy link
Collaborator

hffvld commented Aug 23, 2023

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 [iOS 16.6]
Brave build: 1.57 (23.8.21.22)
BraveCore: 1.57.47 (116.0.5845.96)

FIled follow-up issue #7920 and #7921

Upgraded flow. `Block Cookie Consent Notices` is ON

STEPS:

  1. Install build 1.56
  2. Launch Brave and go through the onboarding flow until landed on NTP
  3. Close and relaunch Brave until you see the Cookie consent notice pop-up
  4. Select Yes, block cookie consent notices
  5. Three-dot menu > Settings > Brave Shields & Privacy
  6. Confirm that the Block Cookie Consent Notices toggle switch is ON
  7. Upgrade Brave to build 1.57 and launch it > Verify
  8. Three-dot menu > Settings > Brave Shields & Privacy > Block Cookie Consent Notices > Verify
  9. Go back and open https://razer.com or https://anker.com > Verify

ACTUAL RESULTS:

  • Verified that the Cookie consent notice pop-up is not shown again after the upgrade since the user already made a choice in the previous Brave version
  • Verified that the Block Cookie Consent Notices toggle switch is ON after the upgrade
  • Verified that Block Cookie Consent Notices is working properly when the toggle switch is ON or OFF

Cookies_upgrade_ON.mov
Upgraded flow. `Block Cookie Consent Notices` is OFF

STEPS:

  1. Install build 1.56
  2. Launch Brave and go through the onboarding flow until landed on NTP
  3. Close and relaunch Brave until you see the Cookie consent notice pop-up
  4. Select No thanks
  5. Three-dot menu > Settings > Brave Shields & Privacy
  6. Confirm that the Block Cookie Consent Notices toggle switch is OFF
  7. Upgrade Brave to build 1.57 and launch it > Verify
  8. Three-dot menu > Settings > Brave Shields & Privacy > Block Cookie Consent Notices > Verify
  9. Go back and open https://razer.com or https://anker.com > Verify

ACTUAL RESULTS:

  • Verified that the Cookie consent notice pop-up is not shown again after the upgrade since the user already made a choice in the previous Brave version
  • Verified that the Block Cookie Consent Notices toggle switch is OFF after the upgrade
  • Verified that Block Cookie Consent Notices is working properly when the toggle switch is ON or OFF

Cookies_upgrade_OFF.mov
Fresh install

STEPS:

  1. Install build 1.57
  2. Launch Brave and go through the onboarding flow until landed on NTP
  3. Close and relaunch Brave until you see the Cookie consent notice pop-up
  4. Tap Got it or anywhere outside of the pop-up message
  5. Three-dot menu > Settings > Brave Shields & Privacy > Block Cookie Consent Notices > Verify
  6. Go back and open https://razer.com or https://anker.com > Verify

ACTUAL RESULTS:

  • Verified that the Cookie consent notice pop-up is shown after Brave fresh install
  • Verified that the Block Cookie Consent Notices toggle switch is ON by default
  • Verified that Block Cookie Consent Notices is working properly when the toggle switch is ON or OFF

1 2 3
1 2 3
Cookie_Fresh.install.mov

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
…fault (brave/brave-ios#7883)

* Enable cookie consent notice blocking by default

* Fix tests
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants