"Block Cookie Consent Notices" settings are not applied without Brave relaunch

[hffvld]

Description:

"Block Cookie Consent Notices" settings are not applied without Brave relaunch for some websites like https://anker.com. Also, the cookies consent message for some websites like https://razer.com is not shown at all when the toggle switch is ON, but for other websites like https://anker.com, the message is shown for a moment and then disappears.

Steps to Reproduce

1. Install build 1.57
2. Launch Brave and go through the onboarding flow until landed on NTP
3. Close and relaunch Brave until you see the Cookie consent notice pop-up
4. Tap Got it or anywhere outside of the pop-up message
5. Three-dot menu > Settings > Brave Shields & Privacy > Confirm that Block Cookie Consent Notices is ON
6. Go back and open https://razer.com and https://anker.com > Observe
7. Go back to Settings and switch Block Cookie Consent Notices to OFF
8. Refresh https://razer.com and https://anker.com > Observe

Actual result:

• Observed that the cookies consent message for https://anker.com is shown for a moment and then disappears. The same issue is not observed for the https://razer.com website.
• Observed that changes to Block Cookie Consent Notices are not applied for https://anker.com without restarting the Brave. The same issue is not observed for the https://razer.com website.

Cookie_Fresh.install.mov

Expected result:

Changes to Block Cookie Consent Noticesmust be applied without restarting the Brave, and the cookies consent message must not be shown for a moment for some websites when the toggle switch is ON.

Reproduces how often: [Easily reproduced, Intermittent Issue]

Easily reproduced

Brave Version:

Brave build: 1.57 (23.8.21.22)
BraveCore: 1.57.47 (116.0.5845.96)

• Can you reproduce this issue with the most recent build from TestFlight? Yes
• Can you reproduce this issue with the previous version of the current build from TestFlight? NA
• Can you reproduce this issue with the current build from AppStore? NA

Device details:

Device/OS: iPhone 14 [iOS 16.6]

Website problems only:

• did you check with Brave Shields down?
• did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

[cuba]

@vlad-hoff I looked at this issue and well I don't think this ticket is an regression:

1. There may be delays with hiding content depending on the rule and the structure of the content. This is known and unfortunate but this is the battle of performance and usability. Perhaps we can investigate how we can speed this up but changing this is risky and indeterministic and outside the reasonable timeframe for this release. It's also not a new issue as this potential delay was always there.
2. When toggling the setting, the effect is not immediate. Again, due to performance reasons. The engines need to be recompiled and this may take several seconds off (sometimes 10 or more) and is done in the background. I did see this delay but I don't see that restarting the browser was necessary. I think it seemed that the settings were immediate for one site simply because of timing. Recompilation of engines happens every 10 seconds so it depends on when you changed the setting and how long it took you to get back to the page and refresh it. This also shouldn't be a new issue. I can investigate improvements but again this will take time and probably outside of a reasonable timeframe for this release.

cc @pes10k

[anthonypkeane]

@vlad-hoff

It seems like it takes the a little time for the changes to the filter list to be applied, I’m fine with what @cuba has for this issue as-is but @cuba mind creating a follow up issue where any improvements to this can be tracked?

@vlad-hoff okay on my side to release as-is, not a blocker unless @pes10k or others disagree

[hffvld]

1. I installed a fresh Brave build and checked more than 50 random websites (news, banks, travel, shopping, etc.). I still see the issue where cookie message is shown for a moment and disappears. It took me 30 min to test it, so I'm sure that the rules are applied already.
   I see the message on delta.com, anker.com, aukey.com, for example, but the message is not shown at all on most of the websites.
2. I see that toggling On and Off is taking some time to apply new rules.

[cuba]

@vlad-hoff
Here are the issues I created:

• Improve the speed of cosmetic filtering #7954
• Improve the speed of compiling engines #7955

[iccub]

Let's close this one in favor of the 2 issues Jacob created?