Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

[iOS] Opt-out cookie consent notice #7792

Closed
timchilds opened this issue Jul 27, 2023 · 1 comment · Fixed by #7890
Closed

[iOS] Opt-out cookie consent notice #7792

timchilds opened this issue Jul 27, 2023 · 1 comment · Fixed by #7890

Comments

@timchilds
Copy link
Collaborator

timchilds commented Jul 27, 2023

Description

Implement the cookie consent notice as opt-out. Same display logic as the old notice before it was disabled.

image

  • Got it = keep cookie consent filter enabled (it's enabled by default).
  • Stop blocking = disable cookie consent filter.

Figma

https://www.figma.com/file/cL22PpqneTYxJePORxUBKz/Cookie-consent-blocker?type=design&node-id=1242%3A44596&mode=design&t=FSGniL2oAsfIVxUT-1

@hffvld
Copy link
Collaborator

hffvld commented Aug 24, 2023

Verified on iPhone 14 and iPad Air using version(s):

Device/OS: 
- iPhone 14 [iOS 17.0]
- iPad Air [iPadOS 16.5.1]
Brave build: 1.57 (23.8.24.17)
BraveCore: 1.57.53 (116.0.5845.114)

Upgraded flow. `Block Cookie Consent Notices` is ON

STEPS:

  1. Install build 1.56
  2. Launch Brave and go through the onboarding flow until you land on NTP
  3. Close and relaunch Brave until you see the Cookie consent notice pop-up
  4. Select Yes, block cookie consent notices
  5. Three-dot menu > Settings > Brave Shields & Privacy
  6. Confirm that the Block Cookie Consent Notices toggle switch is ON
  7. Upgrade Brave to build 1.57 and launch it > Verify
  8. Three-dot menu > Settings > Brave Shields & Privacy > Block Cookie Consent Notices > Verify

ACTUAL RESULTS:

  • Verified that the Cookie consent notice pop-up is not shown again after the upgrade since the user already made a choice in the previous Brave version
  • Verified that the Block Cookie Consent Notices toggle switch is ON after the upgrade
  • Verified that Block Cookie Consent Notices is working properly when the toggle switch is ON or OFF

iPhone

Cookies_upgrade_ON.mov

IPad

Cookies_ipad_upgrade_ON.mov
Upgraded flow. `Block Cookie Consent Notices` is OFF

STEPS:

  1. Install build 1.56
  2. Launch Brave and go through the onboarding flow until you land on NTP
  3. Close and relaunch Brave until you see the Cookie consent notice pop-up
  4. Select No thanks
  5. Three-dot menu > Settings > Brave Shields & Privacy
  6. Confirm that the Block Cookie Consent Notices toggle switch is OFF
  7. Upgrade Brave to build 1.57 and launch it > Verify
  8. Three-dot menu > Settings > Brave Shields & Privacy > Block Cookie Consent Notices > Verify

ACTUAL RESULTS:

  • Verified that the Cookie consent notice pop-up is not shown again after the upgrade since the user already made a choice in the previous Brave version
  • Verified that the Block Cookie Consent Notices toggle switch is OFF after the upgrade

iPhone

Cookies_upgrade_OFF.mov

iPad

Cookies_upgrade_OFF_ipad.mov
Fresh install

STEPS:

  1. Install build 1.57
  2. Launch Brave and go through the onboarding flow until you land on NTP
  3. Close and relaunch Brave until you see the Cookie consent notice pop-up
  4. Tap Got it or anywhere outside of the pop-up message
  5. Three-dot menu > Settings > Brave Shields & Privacy > Block Cookie Consent Notices > Verify
  6. Go back and open https://razer.com or https://anker.com > Verify

ACTUAL RESULTS:

  • Verified that the Cookie consent notice pop-up is shown after Brave fresh install
  • Verified that the Block Cookie Consent Notices toggle switch is ON by default
  • Verified that Block Cookie Consent Notices is working properly when the toggle switch is ON or OFF

1 2 3 4
1 2 3 4
1 2 3 4

iPhone

Cookies_fresh.mov

iPad

Cookies_fresh_ipad.mov

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants