Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix#7792: Add cookie consent notice popup #7890

Merged
merged 2 commits into from
Aug 18, 2023

Conversation

cuba
Copy link
Contributor

@cuba cuba commented Aug 17, 2023

Summary of Changes

Add a dialogue informing the user of cookie consent notice blocking

This pull request fixes #7792

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Launch the application several times and go through some onboarding. At one point you should get this dialogue.

Screenshots:

Simulator Screenshot - iPhone 14 Pro - 2023-08-17 at 09 40 57
Simulator Screenshot - iPhone 14 Pro - 2023-08-17 at 09 41 09

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@cuba cuba requested a review from a team as a code owner August 17, 2023 15:45
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One design decision to make sure is correct. I believe we should not show the opt out for existing users, as they saw the first opt in prompt already

@cuba
Copy link
Contributor Author

cuba commented Aug 17, 2023

One design decision to make sure is correct. I believe we should not show the opt out for existing users, as they saw the first opt in prompt already

Well existing users will not get this popup because I'm using the same setting value that opt in users got. Their settings will stay untouched and this popup won't appear since existing users already got a chance to chose what they wanted

@cuba cuba force-pushed the js/7792-cookie-consent-popup branch from 27cfee5 to 898eea9 Compare August 17, 2023 16:33
Copy link
Contributor

@iccub iccub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we had some small UI concerns. they are low priority and can be fixed separately

@iccub iccub added this to the 1.57 milestone Aug 18, 2023
@iccub iccub merged commit ec757aa into development Aug 18, 2023
@iccub iccub deleted the js/7792-cookie-consent-popup branch August 18, 2023 13:14
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[iOS] Opt-out cookie consent notice
2 participants