Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Frontend iOS support for running DiscoverAssets on page refresh #6652

Closed
nvonpentz opened this issue Dec 13, 2022 · 1 comment · Fixed by #6751
Closed

Frontend iOS support for running DiscoverAssets on page refresh #6652

nvonpentz opened this issue Dec 13, 2022 · 1 comment · Fixed by #6751
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet OS/iOS QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.48

Comments

@nvonpentz
Copy link
Member

Same as brave/brave-browser#26547 but for iOS.
@StephenHeaps StephenHeaps transferred this issue from brave/brave-browser Dec 16, 2022
@StephenHeaps StephenHeaps self-assigned this Jan 12, 2023
@StephenHeaps StephenHeaps moved this from Backlog to In Progress in Web3 Jan 12, 2023
This was referenced Jan 12, 2023
Closed
Merged
StephenHeaps added a commit that referenced this issue Jan 16, 2023
@StephenHeaps
Fix #6652: Asset auto-discovery on wallet open (#6751)
fb96c48 
Call `discoverAssetsOnAllSupportedChains` when Wallet is opened. Show loading state beside Assets in Section title.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Jan 16, 2023
@iccub iccub added this to the 1.48 milestone Feb 2, 2023
@srirambv
Copy link
Contributor

srirambv commented Feb 13, 2023 •
edited
Loading

Verification passed on the following devices running 1.

  • Verified steps from #6751
  • Verified loading spinner next to asset when fetching asset info
  • Verified asset list is shown
  • Encountered #6929 on iOS 15.7.1
iPhone 7+ (iOS 14.8.1) iPad Pro (16.2)
6652-iPhone.7+.MP4
6652-iPad.Pro.MP4

@yrliou yrliou mentioned this issue Feb 23, 2023
Open
15 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet OS/iOS QA Pass - iPad QA Pass - iPhone QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.48
Development

Successfully merging a pull request may close this issue.

Fix #6652: Asset auto-discovery on wallet open brave/brave-ios
4 participants
@StephenHeaps @iccub @nvonpentz @srirambv