-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frontend desktop support for running DiscoverAssets on page refresh #26547
Labels
feature/web3/wallet
Integrating Ethereum+ wallet support
front-end-change
This task is a front end task and doesn't need any C++ changes
OS/Desktop
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Milestone
Comments
nvonpentz
added
QA/Yes
release-notes/include
feature/web3/wallet
Integrating Ethereum+ wallet support
OS/Desktop
front-end-change
This task is a front end task and doesn't need any C++ changes
labels
Nov 4, 2022
We should use one single row "loading skeleton" at the bottom of any list on load and until the final completion/failure call has been executed. |
@jamesmudgett should the OnDiscoverAssetsCompleted event the frontend receives contain data on whether the calls succeeded or failed, or just that they are complete? |
25 tasks
nvonpentz
changed the title
Frontend support for running DiscoverAssets on page refresh
Frontend desktop support for running DiscoverAssets on page refresh
Dec 13, 2022
This was referenced Dec 13, 2022
Repository owner
moved this from In Review
to Done
in Web3
Dec 13, 2022
Verification passed on
26547.mp4Verification passed on
26547.mp4Verification passed on
26547.mov |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature/web3/wallet
Integrating Ethereum+ wallet support
front-end-change
This task is a front end task and doesn't need any C++ changes
OS/Desktop
QA Pass-Linux
QA Pass-macOS
QA Pass-Win64
QA/Yes
release-notes/include
Background
Backend support issue - #25820.
The backend will provide a DiscoverAssetsOnAllSupportedChains API to the frontend that it can call to run the discover assets logic when the user reloads the wallet UI. The API will look like this with with no callback:
Upon completion/failure, the backend will emit an event for each chain.
If it's useful for the frontend, the backend can also emit an event when discovery logic completes for all supported chains.
Spec
More input needed to determine the the specifics, but the frontend implementation should be something like this --
The text was updated successfully, but these errors were encountered: