Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Frontend Android support for running DiscoverAssets on page refresh #27344

Closed
nvonpentz opened this issue Dec 13, 2022 · 1 comment · Fixed by brave/brave-core#16768
Closed

Frontend Android support for running DiscoverAssets on page refresh #27344

nvonpentz opened this issue Dec 13, 2022 · 1 comment · Fixed by brave/brave-core#16768
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.49.x - Release

Comments

@nvonpentz
Copy link
Member

Same as #26547 but for Android.
@nvonpentz nvonpentz added release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality front-end-change This task is a front end task and doesn't need any C++ changes labels Dec 13, 2022
@nvonpentz nvonpentz added this to Web3 Dec 13, 2022
@HEagle18 HEagle18 moved this to Backlog in Web3 Dec 16, 2022
@HEagle18 HEagle18 added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 16, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jan 20, 2023
Merged
25 tasks
@Pavneet-Sing Pavneet-Sing self-assigned this Jan 20, 2023
@Pavneet-Sing Pavneet-Sing moved this from Backlog to In Review in Web3 Jan 20, 2023
@Pavneet-Sing Pavneet-Sing added this to the 1.49.x - Nightly milestone Jan 20, 2023
@github-project-automation github-project-automation bot moved this from In Review to Done in Web3 Jan 23, 2023
@yrliou yrliou mentioned this issue Feb 23, 2023
Open
15 tasks
@srirambv
Copy link
Contributor

srirambv commented Mar 3, 2023

Verification passed on Lenovo Tab with Android 12 running 1.49.118 x64 build

  • Verified steps from brave/brave-core#16768
  • Verified asset auto discovery spinner icon is shown when loading assets
    image

This was referenced Mar 10, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): implement auto asset discovery brave/brave-core
4 participants
@Pavneet-Sing @HEagle18 @nvonpentz @srirambv