Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Asset auto-discovery support #6705

Closed
StephenHeaps opened this issue Jan 5, 2023 · 1 comment
Closed

Asset auto-discovery support #6705

StephenHeaps opened this issue Jan 5, 2023 · 1 comment
Labels
closed/duplicate

Comments

@StephenHeaps
Copy link
Contributor

Description:

iOS version of brave/brave-browser#26547

Currently the asset discovery logic is run when new accounts are added. With this approach we will not discover tokens sent to the user after they have added their account.. We should call this new KeyringService::DiscoverAssetsOnAllSupportedChains() api when the wallet opens, and display some loading UI indicating that we are searching for assets until the onDiscoverAssetsCompleted delegate method is called.
@StephenHeaps StephenHeaps added this to Web3 Jan 5, 2023
@StephenHeaps StephenHeaps moved this to Backlog in Web3 Jan 5, 2023
@StephenHeaps StephenHeaps self-assigned this Jan 9, 2023
@StephenHeaps StephenHeaps moved this from Backlog to In Progress in Web3 Jan 9, 2023
@StephenHeaps StephenHeaps moved this from In Progress to Done in Web3 Jan 12, 2023
@StephenHeaps
Copy link
Contributor Author

Duplicate of #6652

@StephenHeaps StephenHeaps marked this as a duplicate of #6652 Jan 12, 2023
@StephenHeaps StephenHeaps closed this as not planned Won't fix, can't repro, duplicate, stale Jan 12, 2023
@StephenHeaps StephenHeaps removed this from Web3 Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
closed/duplicate
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StephenHeaps @iccub