Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Wallet: Send Screen auto-dismissed #6460

Closed
nuo-xu opened this issue Nov 23, 2022 · 1 comment · Fixed by #6463
Closed

Wallet: Send Screen auto-dismissed #6460

nuo-xu opened this issue Nov 23, 2022 · 1 comment · Fixed by #6463

Comments

@nuo-xu
Copy link
Contributor

nuo-xu commented Nov 23, 2022

Description:

if you go to Buy/Send/Swap Screen from asset detail, those screens will auto-dismissed

  1. if you change selected account
  2. if you change your selected network
  3. if asset detail finishes loading at the background

Steps to Reproduce

  1. open brave wallet
  2. go to any asset detail
  3. click either buy/send/swap
  4. click account picker
  5. change to another account

Actual result:
account list will dismiss, and right after, buy/send/swap screen will be dismissed as well

Expected result:
should stay at buy/send/swap screen

Reproduces how often: [Easily reproduced]

@nuo-xu nuo-xu self-assigned this Nov 23, 2022
@nuo-xu nuo-xu added this to the 1.45.2 milestone Nov 23, 2022
nuo-xu added a commit that referenced this issue Nov 23, 2022
wallet prompt view can be dismissed if there is no Buy/Send/Swap destination
nuo-xu added a commit that referenced this issue Nov 23, 2022
wallet prompt view can be dismissed if there is no Buy/Send/Swap destination
@nuo-xu nuo-xu added the QA/Yes label Nov 23, 2022
@srirambv
Copy link
Contributor

Verification passed on iPhone 7+ with iOS 14.8.1 running 1.45.2 (22.11.23.16)

  • Verified steps from issue description and #6463
  • Verified send screen doesn't auto-dismiss when selecting Send form portfolio or token details screen
  • Verified send screen doesn't auto-dismiss for NFT or Tokens

Verification passed on iPhone XR with iOS 14.8.1 running 1.45.2 (22.11.23.16)

  • Verified steps from issue description and #6463
  • Verified send screen doesn't auto-dismiss when selecting Send form portfolio or token details screen
  • Verified send screen doesn't auto-dismiss for NFT or Tokens

Verification passed on iPad Pro with iOS 16.1 running 1.45.2 (22.11.23.16)

  • Verified steps from issue description and #6463
  • Verified send screen doesn't auto-dismiss when selecting Send form portfolio or token details screen
  • Verified send screen doesn't auto-dismiss for NFT or Tokens

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.