Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #6460: Buy/Send/Swap autodismiss from asset detail screen #6463

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

nuo-xu
Copy link
Contributor

@nuo-xu nuo-xu commented Nov 23, 2022

Summary of Changes

When Buy/Send/Swap is current presented, WalletPromptView will not trigger any top view controller to be dismissed.

This pull request fixes #6460

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

  1. open brave wallet
  2. go to any asset detail screen that has buy/send/swap option
  3. try to click those option quickly before asset detail is loaded
  4. observe buy/send/swap will not be dismissed after details screen is loaded at the back
  5. you can also try to change selected account or selected network in buy/send/swap
  6. observe buy/send/swap screen will be not be dismissed after you changed selected account/network

Screenshots:

Simulator.Screen.Recording.-.iPhone.SE.3rd.generation.-.2022-11-23.at.09.58.28.mp4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

@nuo-xu nuo-xu added this to the 1.45.2 milestone Nov 23, 2022
@nuo-xu nuo-xu requested review from StephenHeaps and a team November 23, 2022 14:59
@nuo-xu nuo-xu self-assigned this Nov 23, 2022
@nuo-xu nuo-xu merged commit 4412ac2 into development Nov 23, 2022
@nuo-xu nuo-xu deleted the wallet/buysendswap-autodismiss-issue branch November 23, 2022 15:39
nuo-xu added a commit that referenced this pull request Nov 23, 2022
wallet prompt view can be dismissed if there is no Buy/Send/Swap destination
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wallet: Send Screen auto-dismissed
2 participants