Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #7200: Tx Confirmation auto-dismisses after creating tx via asset details #7203

Merged
merged 2 commits into from
Apr 5, 2023

Conversation

StephenHeaps
Copy link
Contributor

@StephenHeaps StephenHeaps commented Apr 4, 2023

Summary of Changes

  • Fix Transaction Confirmation automatically dismissing after creating a send/swap transaction from asset details

This pull request fixes #7200

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()
  • New or updated UI has been tested across:
    • Light & dark mode
    • Different size classes (iPhone, landscape, iPad)
    • Different dynamic type sizes

Test Plan:

Verify no regressions with popup (Aurora bridge, Biometrics popup):

  1. Create a new wallet and verify 'Enable' toggle works on Biometrics prompt (dismisses the popup).
  2. Restore wallet and verify 'Enable' toggle works on Biometrics prompt (dismisses the popup).
  3. Open Portfolio and tap an Aurora Bridge supported asset (ex. Ethereum on Etheruem Mainnet).
  4. Tap Bridge to Aurora
  5. Verify the popup closes and opens the Rainbow Bridge url.
  6. Open Portfolio and tap an Aurora Bridge supported asset (ex. Ethereum on Etheruem Mainnet).
  7. Tap 'Do not show again' and verify the popup closes.

Verify no regression with #6460

  1. Open Portfolio
  2. Select any asset and tap Buy/Send/Swap on asset details
  3. Change network or selected account and verify Buy/Send/Swap is not dismissed automatically

Verify bug fix:

  1. Open Portfolio and tap an asset with a balance on one of your accounts
  2. Tap send or swap
  3. Tap Send or Swap the send or swap transaction
  4. Verify Transaction Confirmation modal is displayed as expected, does not auto-dismiss.

Screenshots:

7200.mp4

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue and pull request is assigned to a milestone (should happen at merge time).

…sing Transaction Confirmation to dismiss automatically after creating a Send/Swap transaction via Asset Details.
…t we only dismiss the presented view controller if we know we presented it.
@StephenHeaps StephenHeaps added this to the 1.50 milestone Apr 4, 2023
@StephenHeaps StephenHeaps requested a review from nuo-xu April 4, 2023 19:59
@StephenHeaps StephenHeaps requested a review from a team as a code owner April 4, 2023 19:59
@StephenHeaps StephenHeaps self-assigned this Apr 4, 2023
@StephenHeaps StephenHeaps merged commit 00dd731 into development Apr 5, 2023
@StephenHeaps StephenHeaps deleted the wallet/tx-confirm-auto-dismiss branch April 5, 2023 15:28
Brandon-T pushed a commit that referenced this pull request Apr 11, 2023
… details (#7203)

* Fix `WalletPromptView` dismissing views unintentionally. This was causing Transaction Confirmation to dismiss automatically after creating a Send/Swap transaction via Asset Details.

* Remove `buySendSwapDestination` check from `WalletPromptView` now that we only dismiss the presented view controller if we know we presented it.
iccub pushed a commit that referenced this pull request Apr 12, 2023
… details (#7203)

* Fix `WalletPromptView` dismissing views unintentionally. This was causing Transaction Confirmation to dismiss automatically after creating a Send/Swap transaction via Asset Details.

* Remove `buySendSwapDestination` check from `WalletPromptView` now that we only dismiss the presented view controller if we know we presented it.
@iccub iccub modified the milestones: 1.50, 1.49.1 Apr 12, 2023
arthuredelstein pushed a commit to brave/brave-core that referenced this pull request Feb 13, 2024
…ng tx via asset details (brave/brave-ios#7203)

* Fix `WalletPromptView` dismissing views unintentionally. This was causing Transaction Confirmation to dismiss automatically after creating a Send/Swap transaction via Asset Details.

* Remove `buySendSwapDestination` check from `WalletPromptView` now that we only dismiss the presented view controller if we know we presented it.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tx Confirmation presented over Asset Detail dismisses automatically
3 participants