Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Wallet: Support sending transactions to a domain (ENS) #5787

Closed
StephenHeaps opened this issue Aug 4, 2022 · 1 comment · Fixed by #7030
Closed

Wallet: Support sending transactions to a domain (ENS) #5787

StephenHeaps opened this issue Aug 4, 2022 · 1 comment · Fixed by #7030
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.49

Comments

@StephenHeaps
Copy link
Contributor

StephenHeaps commented Aug 4, 2022 •
edited
Loading

Description:

Update send transaction view / logic to support sending to a domain.

ref / more info:
https://bravesoftware.slack.com/archives/C023VS4HJ6Q/p1659646211852199
brave/brave-browser#18681
brave/brave-browser#18656
@StephenHeaps StephenHeaps added this to Web3 Aug 4, 2022
@StephenHeaps StephenHeaps changed the title Wallet: Support sending transactions to a url Wallet: Support sending transactions to a domain Aug 4, 2022
@jamesmudgett jamesmudgett moved this to Backlog in Web3 Aug 12, 2022
@StephenHeaps StephenHeaps changed the title Wallet: Support sending transactions to a domain Wallet: Support sending transactions to a domain (ENS) Oct 14, 2022
@StephenHeaps StephenHeaps self-assigned this Feb 13, 2023
@StephenHeaps StephenHeaps moved this from Backlog to In Progress in Web3 Feb 13, 2023
This was referenced Feb 28, 2023
Merged
Closed
@StephenHeaps StephenHeaps added this to the 1.49 milestone Mar 7, 2023
StephenHeaps added a commit that referenced this issue Mar 9, 2023
@StephenHeaps
Fix #5787: Send to ENS wallet address (#7030)
efac58e 
* Support sending to an ENS domain in a native send transaction, including offchain ENS.

* Add ENS Offchain preference and hyperlink to `Web3DomainSettingsView`

* Unit tests for verifying ENS resolution, ENS Offchain consent required, ENS failure, creating Ethereum transaction using resolved address.

* Use iOS 15+ open url action now that iOS 14 support is dropped. Update UI/UX for ENS preference to use markdown
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Mar 9, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.49 (23.3.9.17)

  • Verified steps from #7030
  • Verified Offchain lookup works as expected
  • Verified clicking on Learn more loads Wiki page about ENS lookup
  • Verified Settings is set to Ask by default
  • Verified setting is set to Enabled when Use ENS Domain is selected
  • Verified when setting is set to Disabled , offchainexample.eth domain lookup fails
  • Encountered #7079
iPhone 7+ (iOS 15.7.3) iPhone XR (iOS 16.3.1) iPad Pro (16.4 Beta 2)
5787-iPhone.7+.MP4
5787-iPhone.XR.MP4
5787-iPad.MP4

@Uni-verse Uni-verse mentioned this issue Apr 13, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#5787: Send to ENS wallet address (brave/brave-ios…
3005b48 
…#7030)

* Support sending to an ENS domain in a native send transaction, including offchain ENS.

* Add ENS Offchain preference and hyperlink to `Web3DomainSettingsView`

* Unit tests for verifying ENS resolution, ENS Offchain consent required, ENS failure, creating Ethereum transaction using resolved address.

* Use iOS 15+ open url action now that iOS 14 support is dropped. Update UI/UX for ENS preference to use markdown
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.49
Development

Successfully merging a pull request may close this issue.

Fix #5787: Send to ENS wallet address brave/brave-ios
2 participants
@StephenHeaps @srirambv