Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Allow users navigate to .eth domains (ENS) #6225

Closed
srirambv opened this issue Oct 21, 2022 · 2 comments · Fixed by #7153
Closed

Allow users navigate to .eth domains (ENS) #6225

srirambv opened this issue Oct 21, 2022 · 2 comments · Fixed by #7153
Assignees
@StephenHeaps
Labels
Epic: Brave Wallet priority/P3 The next thing for us to work on. QA Pass - iPhone X QA/Yes release-notes/include
Milestone
1.60

Comments

@srirambv
Copy link
Contributor

srirambv commented Oct 21, 2022 •
edited by StephenHeaps
Loading

Support navigating to ENS domain in omnibox, including offchain lookup. The default setting should be to ask the user before proceeding to lookup the domain. If the lookup returns

Allow ENS Interstitial Allow ENS Offchain Interstitial
ENS interstitial ENS Offchain interstitial

ENS wallet address resolution including offchain lookup is handled via: #5787
@srirambv srirambv added this to Web3 Oct 21, 2022
@nuo-xu nuo-xu changed the title Support ENS wildcard resolution Android implementation of #24430 Support ENS wildcard resolution iOS implementation of #24430 Oct 21, 2022
@nuo-xu
Copy link
Contributor

nuo-xu commented Oct 21, 2022

Note: iOS does not support IPFS at this moment.

@jamesmudgett jamesmudgett moved this to Backlog in Web3 Oct 22, 2022
@StephenHeaps StephenHeaps changed the title Support ENS wildcard resolution iOS implementation of #24430 Allow users navigate to .eth domains (ENS) Mar 1, 2023
@StephenHeaps StephenHeaps self-assigned this Mar 1, 2023
@StephenHeaps StephenHeaps moved this from Backlog to In Progress in Web3 Mar 7, 2023
@StephenHeaps StephenHeaps mentioned this issue Mar 27, 2023
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Apr 6, 2023
@StephenHeaps
Fix #6225: Ethereum Name Service (ENS) Navigation (#7153)
010ed0d 
* Add ENS Resolve Method preference to `Web3DomainSettingsView`

* Refactor `SNSDomain.html`, `SNSDomain.css`, `SNSDomainHandler`, `Web3NameServiceScriptHandler` to be more generic. Support for SNS, ENS and ENS Offchain (and later Unstoppable Domains can re-use).
Integrate initial support for ENS navigation via omnibar (supported until IPFS url received).

* Add new `DecentralizedDNSHelper` to contain decentralized DNS logic to `BraveWallet` target

* Add `DecentralizedDNSHelperTests` for unit testing `DecentralizedDNSHelper`. Update `SettingsStoreTests` for testing `ensResolveMethod` in setup.

* Close keyboard / leave overlay mode when resolving decentralized DNS. Update selected tab loading state when user presses stop.

* Use a single `Web3DomainHandler` by storing service id in url query.

* Verify URL is not a bookmarklet / javascript before returning in `DecentralizedDNSHelper`.

* Support decentralized DNS links when tapped on a website (main-frame only).
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Apr 6, 2023
@iccub iccub added this to the 1.59 milestone Oct 6, 2023
@srirambv
Copy link
Contributor Author

Verification passed on iPhone 13 with iOS 17.2 running 1.60 (23.11.12.17)

  • Verified steps from #7153
  • Verified settings for Resolve Solana Name Service (SNS) Domain Names is set to Ask as default
  • Verified settings for Resolve Ethereum Name Service (ENS) Domain Names is set to Ask as default
  • Verified settings for Allow ENS Offchain Lookup is set to Ask as default
  • Verified visiting https://offchainexample.eth brings up ENS interstitial page
  • Verified selecting Disable on interstitial page sets ENS lookup setting to disabled
  • Verified selecting Proceed using Infura brings up Offchain lookup interstitial page
  • Verified selecting Disable on offchain lookup disables ENS offchain lookup setting to disable
  • Verified selecting Proceed with offchain lookup brings up IPFS interstitial page
  • Verified visiting https://onybose.sol brings up SNS interstitial page
  • Verified selecting Disable on interstitial page sets SNS lookup setting to disabled
  • Verified selecting Proceed using Syndica server sets SNS to enabled and redirects to https://anirudha.co
6225.MP4

@Uni-verse Uni-verse mentioned this issue Dec 20, 2023
Closed
arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#6225: Ethereum Name Service (ENS) Navigation (bra…
cb7cfc3 
…ve/brave-ios#7153)

* Add ENS Resolve Method preference to `Web3DomainSettingsView`

* Refactor `SNSDomain.html`, `SNSDomain.css`, `SNSDomainHandler`, `Web3NameServiceScriptHandler` to be more generic. Support for SNS, ENS and ENS Offchain (and later Unstoppable Domains can re-use).
Integrate initial support for ENS navigation via omnibar (supported until IPFS url received).

* Add new `DecentralizedDNSHelper` to contain decentralized DNS logic to `BraveWallet` target

* Add `DecentralizedDNSHelperTests` for unit testing `DecentralizedDNSHelper`. Update `SettingsStoreTests` for testing `ensResolveMethod` in setup.

* Close keyboard / leave overlay mode when resolving decentralized DNS. Update selected tab loading state when user presses stop.

* Use a single `Web3DomainHandler` by storing service id in url query.

* Verify URL is not a bookmarklet / javascript before returning in `DecentralizedDNSHelper`.

* Support decentralized DNS links when tapped on a website (main-frame only).
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
Epic: Brave Wallet priority/P3 The next thing for us to work on. QA Pass - iPhone X QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.60
Development

Successfully merging a pull request may close this issue.

Fix #6225: Ethereum Name Service (ENS) Navigation brave/brave-ios
4 participants
@nuo-xu @StephenHeaps @iccub @srirambv