Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Domain name is resolved when showing the ENS offchain lookup #7079

Closed
srirambv opened this issue Mar 10, 2023 · 1 comment · Fixed by #7080
Closed

Domain name is resolved when showing the ENS offchain lookup #7079

srirambv opened this issue Mar 10, 2023 · 1 comment · Fixed by #7080
Assignees
@StephenHeaps
Labels
bug Epic: Brave Wallet intermittent QA Pass - iPhone X QA/Yes release-notes/exclude
Milestone
1.49

Comments

@srirambv
Copy link
Contributor

Description:

Domain name is resolved when showing the ENS offchain lookup

Steps to Reproduce

  1. Install 1.49 and open Send screen
  2. Type ethereum.eth and wait for domain to resolve
  3. Replace etherum with offchainexample
  4. On ENS offchain lookup message it resolves offchain.eth and shows address

Actual result:

Expected result:

Shouldn't resolve domain names until user stops typing

Reproduces how often: [Easily reproduced, Intermittent Issue]

Happened once

Brave Version:

  • Can you reproduce this issue with the most recent build from TestFlight? Yes
  • Can you reproduce this issue with the previous version of the current build from TestFlight? NA
  • Can you reproduce this issue with the current build from AppStore? NA

Device details:

iPhone XR (iOS 16.3.1)

Website problems only:

  • did you check with Brave Shields down? NA
  • did you check in Safari/Firefox (WkWebView-based browsers)? NA

Additional Information

cc: @StephenHeaps
@srirambv srirambv added this to Web3 Mar 10, 2023
@StephenHeaps StephenHeaps self-assigned this Mar 10, 2023
@StephenHeaps StephenHeaps moved this to In Progress in Web3 Mar 10, 2023
@srirambv srirambv mentioned this issue Mar 10, 2023
Closed
@StephenHeaps StephenHeaps mentioned this issue Mar 10, 2023
Merged
11 tasks
StephenHeaps added a commit that referenced this issue Mar 10, 2023
@StephenHeaps
Fix #7079: Race condition resolving wallet address with ENS (#7080)
d625b06 
* Fix race condition with ENS/SNS. Verify the domain we are resolving is exact same as the currently entered `sendAddress` before assigning the resolved address.
@github-project-automation github-project-automation bot moved this from In Progress to Done in Web3 Mar 10, 2023
@iccub iccub added this to the 1.49 milestone Mar 21, 2023
@srirambv
Copy link
Contributor Author

Verification passed on iPhone XR with iOS 16.3.1 running 1.49 (23.3.23.15)

  • Verified steps from issue description and #7079
  • Verified domain name isn't shown when showing ENS offchain lookup message
7079.MP4

arthuredelstein pushed a commit to brave/brave-core that referenced this issue Feb 13, 2024
@StephenHeaps
Fix brave/brave-ios#7079: Race condition resolving wallet address wit…
0284ca6 
…h ENS (brave/brave-ios#7080)

* Fix race condition with ENS/SNS. Verify the domain we are resolving is exact same as the currently entered `sendAddress` before assigning the resolved address.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@StephenHeaps StephenHeaps

Labels
bug Epic: Brave Wallet intermittent QA Pass - iPhone X QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.49
Development

Successfully merging a pull request may close this issue.

Fix #7079: Race condition resolving wallet address with ENS brave/brave-ios
3 participants
@StephenHeaps @iccub @srirambv