Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Provide time out details for incorrect passcode lockdown #443

Closed
srirambv opened this issue Nov 26, 2018 · 11 comments
Closed

Provide time out details for incorrect passcode lockdown #443

srirambv opened this issue Nov 26, 2018 · 11 comments
Assignees
Labels
enhancement Epic: Pincode Epic for defining issues pertaining to the iOS pincode / passcode lock. priority/P4 Planned work. We expect to get to it "soon". QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone

Comments

@srirambv
Copy link
Contributor

Description:

Provide time out details for incorrect passcode lockdown

Steps to Reproduce

  1. Enable passcode
  2. Try resting passcode with 3 incorrect attempts
  3. Doesn't show how long you should wait before trying again

Actual result:
image

Expected result:
Should inform user how much time to wait before trying to change passcode again

Reproduces how often: [Easily reproduced, Intermittent Issue]
Easy

Brave Version:
1.7(18.11.21.22)

Device details:
iPhone 7+ (iOS 12.1)

Website problems only:

  • did you check with Brave Shields down?
  • did you check in Safari/Firefox (WkWebView-based browsers)?

Additional Information

Once locked out doesn't allow you to login if you remove the app from memory and relaunch app is rendered useless

@kylehickinson
Copy link
Collaborator

Just realized we'll need new copy for this. What is it expected to say? "Please try again in 15m" ? (cc @anthonypkeane)

@anthonypkeane
Copy link

@kylehickinson pls defer this enhancement until after 1.7.0. We can pick it up then.

@srirambv
Copy link
Contributor Author

Yeah it should be more like iOS time out message when you have unsuccessful unlock attempts

@srirambv srirambv added the priority/P4 Planned work. We expect to get to it "soon". label Nov 28, 2018
@jumde jumde assigned iccub and unassigned jumde Mar 6, 2019
@iccub iccub removed their assignment Mar 6, 2019
@anthonypkeane anthonypkeane modified the milestones: 1.14, 1.15 Oct 31, 2019
@anthonypkeane anthonypkeane removed their assignment Nov 6, 2019
@anthonypkeane anthonypkeane modified the milestones: 1.15, 1.14 Nov 6, 2019
@kylehickinson
Copy link
Collaborator

@anthonypkeane Still need copy for this as per above comment

@anthonypkeane
Copy link

Brave is disabled
try again in n minutes

@kylehickinson
Copy link
Collaborator

@anthonypkeane So no more "maximum attempts reached" ?

@anthonypkeane
Copy link

@anthonypkeane So no more "maximum attempts reached" ?

@tomlowenthal can you please confirm the text change?

@tildelowengrimm
Copy link

Too many failed attempts
Try again in $TIME minutes

@srirambv
Copy link
Contributor Author

Verification passed on iPhone XR with iOS 13.2 running 1.14(19.11.19.15)


Verification passed on iPhone 7+ with iOS 13.2 running 1.14(19.11.19.15)


Verification passed on iPad Pro with iOS 13.2 running 1.14(19.11.19.15)


Verification passed on iPhone 6 with iOS 12.4 running 1.14(19.11.19.15)


Verification passed on iPad Pro with iOS 12.4 running 1.14(19.11.19.15)

@anthonypkeane
Copy link

Too many failed attempts
Try again in $TIME minutes

There needs to be a line break after attempts as per the comment from @tomlowenthal
reopening ticket

@anthonypkeane anthonypkeane reopened this Dec 5, 2019
@kylehickinson
Copy link
Collaborator

Let's open up a follow-up ticket and keep this ticket closed since it'll require re-verification and technically "new" translations.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement Epic: Pincode Epic for defining issues pertaining to the iOS pincode / passcode lock. priority/P4 Planned work. We expect to get to it "soon". QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Development

No branches or pull requests

7 participants