Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Formatting on PIN code error #1818

Closed
anthonypkeane opened this issue Oct 29, 2019 · 3 comments
Closed

Formatting on PIN code error #1818

anthonypkeane opened this issue Oct 29, 2019 · 3 comments
Assignees
@kylehickinson
Labels
bug Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Milestone
1.14

Comments

@anthonypkeane
Copy link

Description:

Please fix the formatting on this screen

James, can you provide a design option?

IMG_D093A1055699-1.jpeg
@izabekz izabekz mentioned this issue Oct 30, 2019
Closed
5 tasks
@anthonypkeane anthonypkeane added this to the 1.14 milestone Oct 31, 2019
@kylehickinson kylehickinson modified the milestones: 1.14, 1.15 Nov 6, 2019
@anthonypkeane anthonypkeane modified the milestones: 1.15, 1.14 Nov 6, 2019
@kylehickinson
Copy link
Collaborator

@jamesmudgett Is the solution to this just fixing the background colour of the label to be clear?

@kylehickinson
Copy link
Collaborator

@jamesmudgett confirmed: Going to change text color to red, and get rid of pill background

@jhreis jhreis added the blocked: needs design Needs design before work can commence label Nov 15, 2019
@jhreis jhreis removed this from the 1.14 milestone Nov 15, 2019
@kylehickinson kylehickinson removed the blocked: needs design Needs design before work can commence label Nov 15, 2019
@kylehickinson kylehickinson added this to the 1.14 milestone Nov 15, 2019
@kylehickinson kylehickinson assigned kylehickinson and unassigned iccub Nov 18, 2019
kylehickinson added a commit that referenced this issue Nov 18, 2019
@kylehickinson
Fix #1818: Update error design on PIN code entry/lockout
ff897fe
@kylehickinson kylehickinson mentioned this issue Nov 18, 2019
Merged
7 tasks
kylehickinson added a commit that referenced this issue Nov 18, 2019
@kylehickinson
Fix #1818: Update error design on PIN code entry/lockout
485eb62
@srirambv
Copy link
Contributor

Verification passed on iPhone XR with iOS 13.2 running 1.14(19.11.19.15)

  • Verified new UI on both normal tabs and private tabs
  • Verified new UI on both light and dark theme

Verification passed on iPhone 7+ with iOS 13.2 running 1.14(19.11.19.15)

  • Verified new UI on both normal tabs and private tabs
  • Verified new UI on both light and dark theme

Verification passed on iPad Pro with iOS 13.2 running 1.14(19.11.19.15)

  • Verified new UI on both normal tabs and private tabs
  • Verified new UI on both light and dark theme

Verification passed on iPhone 6 with iOS 12.4 running 1.14(19.11.19.15)

  • Verified new UI on both normal tabs and private tabs
  • Verified new UI on both light and dark theme

Verification passed on iPad Pro with iOS 12.4 running 1.14(19.11.19.15)

  • Verified new UI on both normal tabs and private tabs
  • Verified new UI on both light and dark theme

Screenshots in #443 (comment)

@iccub iccub mentioned this issue Dec 4, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
bug Epic: UI/UX QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.14
Development

No branches or pull requests
6 participants
@jamesmudgett @kylehickinson @jhreis @iccub @anthonypkeane @srirambv