Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Fix #443: Display time out details for incorrect passcode lockdown #1976

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

kylehickinson
Copy link
Collaborator

@kylehickinson kylehickinson commented Nov 18, 2019

Summary of Changes

This pull request fixes issue #443

Submitter Checklist:

  • Unit Tests are updated to cover new or changed functionality
  • User-facing strings use NSLocalizableString()

Test Plan:

  • Enable browser PIN, get locked out, verify minutes left is shown

Screenshots:

1 Minute Many Minutes
Simulator Screen Shot - iPhone 8 - 2019-11-18 at 11 41 35 Simulator Screen Shot - iPhone 8 - 2019-11-18 at 11 43 42

Reviewer Checklist:

  • Issues include necessary QA labels:
    • QA/(Yes|No)
    • release-notes/(include|exclude)
    • bug / enhancement
  • Necessary security reviews have taken place.
  • Adequate unit test coverage exists to prevent regressions.
  • Adequate test plan exists for QA to validate (if applicable).
  • Issue is assigned to a milestone (should happen at merge time).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants