Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Enable downloading of files into the Downloads folder #206

Closed
tmancey opened this issue Aug 30, 2018 · 4 comments
Closed

Enable downloading of files into the Downloads folder #206

tmancey opened this issue Aug 30, 2018 · 4 comments
Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Milestone
1.12

Comments

@tmancey
Copy link
Collaborator

tmancey commented Aug 30, 2018 •
edited
Loading

Enable the UI for downloading of files into the Downloads folder by reverting changes made within #205
@tmancey tmancey added enhancement blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue and removed blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue labels Aug 30, 2018
@tmancey tmancey changed the title Re-enable downloading of files into the Downloads folder Enable downloading of files into the Downloads folder Aug 30, 2018
@tmancey tmancey added won't have Requirement which the project team has agreed it will not deliver and removed blocked If a ticket is blocked for some reason, if not using a sub-block label, please provide info in issue labels Sep 3, 2018
@tmancey tmancey closed this as completed Sep 3, 2018
@tmancey tmancey reopened this Sep 5, 2018
@tmancey tmancey removed the won't have Requirement which the project team has agreed it will not deliver label Sep 6, 2018
@srirambv srirambv mentioned this issue Nov 30, 2018
Closed
@jhreis jhreis added the blocked: needs design Needs design before work can commence label Mar 27, 2019
@jhreis jhreis mentioned this issue Mar 27, 2019
Closed
@btlechowski
Copy link

Because of this issue all binary files are opened as text files in the browser.

STR:

  1. Open https://github.com/brave/brave-browser/releases
  2. Click a zip file

Actual Result:
IMG_0002

cc @brave/legacy_qa

@iccub iccub mentioned this issue Aug 6, 2019
Closed
@iccub iccub removed the blocked: needs design Needs design before work can commence label Aug 6, 2019
@iccub
Copy link
Contributor

iccub commented Aug 6, 2019

Removing needs design label, first iteration will use mostly Firefoxes UI

@jhreis jhreis added this to the 1.12 milestone Aug 22, 2019
@jhreis jhreis closed this as completed in 5330bb3 Aug 27, 2019
This was referenced Sep 5, 2019
Closed
Closed
Closed
@iccub
Copy link
Contributor

iccub commented Sep 6, 2019

Test plan:

@srirambv
Copy link
Contributor

srirambv commented Sep 9, 2019 •
edited
Loading

Verification passed on iPhone XR with iOS 13.1 beta 2 running 1.12

  • Verified on clean install download folder is created in file.app
  • Verified on upgrade install download folder is created in file.app

Verification PASSED on iPad Air 3rd Generation with iOS 13.1 running 1.12 (19.09.07.03):

Verification passed on iPhone 7+ with iOS 12.4.1 running 1.12(19.09.13.06)

  • Verified on clean install download folder is created in file.app
  • Verified on upgrade install download folder is created in file.app

@srirambv srirambv mentioned this issue Oct 3, 2019
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement QA Pass - iPad QA Pass - iPhone X QA Pass - iPhone QA/Yes release-notes/include
Projects
None yet
Milestone
1.12
Development

No branches or pull requests
7 participants
@jamesmudgett @tmancey @kjozwiak @jhreis @iccub @srirambv @btlechowski