Skip to content
This repository has been archived by the owner on May 10, 2024. It is now read-only.

Disable downloading of files into the Downloads folder #205

Closed
tmancey opened this issue Aug 30, 2018 · 1 comment
Closed

Disable downloading of files into the Downloads folder #205

tmancey opened this issue Aug 30, 2018 · 1 comment
Assignees
@kylehickinson
Labels
enhancement
Milestone
Sprint w/e 23rd S...

Comments

@tmancey
Copy link
Collaborator

tmancey commented Aug 30, 2018 •
edited
Loading

Disable the UI for downloading of files into the Downloads folder. This feature will be re-enabled in a future version when privacy concerns have been addressed in #195
@tmancey tmancey mentioned this issue Aug 30, 2018
Closed
@kylehickinson kylehickinson self-assigned this Sep 11, 2018
@kylehickinson
Copy link
Collaborator

kylehickinson commented Sep 11, 2018 •
edited
Loading

This code is actually tied to #185 (this is another instance of their PhotonActionSheet), therefore a future revert of this PR fix would not be clean down the road (PhotonActionSheet will not exist anymore).

Also the DownloadsPanel UI hasn't been in use since we implemented our own FavoritesViewController new tab, so a revert would only bring back the download handling logic.

simulator screen shot - iphone 8 - 2018-09-11 at 12 16 29

Proposal: Remove all current & legacy download UI, but keep all the download business logic in-tact, and later when we want to add this feature we will just need to create our own custom UI to integrate with.

kylehickinson added a commit that referenced this issue Sep 13, 2018
@kylehickinson
Merge pull request #251 from brave/remove-downloads-ui
122b6be 
 Fix #205: Remove download file request flow
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kylehickinson kylehickinson

Labels
enhancement
Projects
None yet
Milestone
Sprint w/e 23rd Sept 2018
Development

No branches or pull requests
2 participants
@kylehickinson @tmancey