-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Brave Ads Serving Improvements #9736
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moritzhaller
force-pushed
the
issues/17236
branch
from
August 12, 2021 08:23
b3bf4b9
to
81ba158
Compare
moritzhaller
force-pushed
the
issues/17236
branch
2 times, most recently
from
August 14, 2021 13:18
efdf641
to
6b43e15
Compare
moritzhaller
changed the title
Implement Brave Ads serving improvements
Implement Brave Ads Serving Improvements
Aug 17, 2021
moritzhaller
force-pushed
the
issues/17236
branch
4 times, most recently
from
August 18, 2021 11:03
0124946
to
59436f3
Compare
moritzhaller
force-pushed
the
issues/17236
branch
4 times, most recently
from
August 23, 2021 17:41
0284b06
to
3392c5e
Compare
tmancey
reviewed
Aug 23, 2021
vendor/bat-native-ads/src/bat/ads/internal/ad_events/ad_event_util.h
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Aug 23, 2021
vendor/bat-native-ads/src/bat/ads/internal/ad_events/ad_event_util.h
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Aug 23, 2021
vendor/bat-native-ads/src/bat/ads/internal/ad_events/ad_event_util_unittest.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Aug 23, 2021
vendor/bat-native-ads/src/bat/ads/internal/ad_events/ad_event_util_unittest.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Aug 23, 2021
...r/bat-native-ads/src/bat/ads/internal/ad_serving/ad_notifications/ad_notification_serving.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Aug 23, 2021
...r/bat-native-ads/src/bat/ads/internal/ad_serving/ad_notifications/ad_notification_serving.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Aug 23, 2021
...r/bat-native-ads/src/bat/ads/internal/ad_serving/ad_notifications/ad_notification_serving.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Aug 23, 2021
...-native-ads/src/bat/ads/internal/ad_serving/ad_notifications/ad_notification_serving_test.cc
Show resolved
Hide resolved
tmancey
reviewed
Aug 23, 2021
...t-native-ads/src/bat/ads/internal/ad_serving/inline_content_ads/inline_content_ad_serving.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Aug 23, 2021
...t-native-ads/src/bat/ads/internal/ad_serving/inline_content_ads/inline_content_ad_serving.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Aug 23, 2021
...t-native-ads/src/bat/ads/internal/ad_serving/inline_content_ads/inline_content_ad_serving.cc
Outdated
Show resolved
Hide resolved
moritzhaller
force-pushed
the
issues/17236
branch
from
August 23, 2021 17:59
3392c5e
to
15149bd
Compare
tmancey
requested changes
Aug 23, 2021
vendor/bat-native-ads/src/bat/ads/internal/ad_targeting/ad_targeting.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/ad_targeting/ad_targeting.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/ad_targeting/ad_targeting.h
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/bundle/creative_ad_info.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/eligible_ads_util_unittest.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/sample_ads.h
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/sample_ads.h
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/sample_ads_unittest.cc
Outdated
Show resolved
Hide resolved
vendor/bat-native-ads/src/bat/ads/internal/features/ad_serving/ad_serving_features.h
Outdated
Show resolved
Hide resolved
aseren
reviewed
Aug 24, 2021
vendor/bat-native-ads/src/bat/ads/internal/ad_events/ad_event_util.h
Outdated
Show resolved
Hide resolved
aseren
reviewed
Sep 22, 2021
...t-native-ads/src/bat/ads/internal/ad_serving/inline_content_ads/inline_content_ad_serving.cc
Outdated
Show resolved
Hide resolved
moritzhaller
force-pushed
the
issues/17236
branch
from
September 22, 2021 09:22
0f2aac6
to
492b00d
Compare
aseren
reviewed
Sep 22, 2021
aseren
reviewed
Sep 22, 2021
vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/sample_ads.h
Outdated
Show resolved
Hide resolved
aseren
reviewed
Sep 22, 2021
...at-native-ads/src/bat/ads/internal/eligible_ads/ad_notifications/eligible_ad_notifications.h
Outdated
Show resolved
Hide resolved
aseren
reviewed
Sep 22, 2021
vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/ad_predictor_info.h
Outdated
Show resolved
Hide resolved
aseren
reviewed
Sep 22, 2021
vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/eligible_ads_predictor_util.h
Outdated
Show resolved
Hide resolved
moritzhaller
force-pushed
the
issues/17236
branch
5 times, most recently
from
September 22, 2021 20:20
4293dbb
to
f0cf771
Compare
tmancey
reviewed
Sep 22, 2021
vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/eligible_ads_features_util.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Sep 22, 2021
vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/eligible_ads_features_util.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Sep 22, 2021
vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/eligible_ads_predictor_util_unittest.cc
Show resolved
Hide resolved
tmancey
reviewed
Sep 22, 2021
vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/sample_ads_unittest.cc
Outdated
Show resolved
Hide resolved
tmancey
reviewed
Sep 22, 2021
vendor/bat-native-ads/src/bat/ads/internal/eligible_ads/sample_ads_unittest.cc
Outdated
Show resolved
Hide resolved
moritzhaller
force-pushed
the
issues/17236
branch
2 times, most recently
from
September 22, 2021 21:35
24e31fb
to
994c25c
Compare
tmancey
approved these changes
Sep 22, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM++
CI/Android failing with unrelated issues |
Currently, ad serving is done by randomly picking ads based on matching segments. The approach has several problems like under-delivery of creatives and users not seeing as many ads as they could. This PR aims to solve these short comings by introducing a statistical model for ad selection. We assume that the click probability can be approximated by a linear function of features related to locally observed user behaviour. The function is weighted by a control-parameter called pass-through rate (ptr) to throttle delivery of individual ads.
moritzhaller
force-pushed
the
issues/17236
branch
from
September 22, 2021 22:19
994c25c
to
97eb067
Compare
aseren
reviewed
Sep 23, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves brave/brave-browser#17236
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
,npm run lint
,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan:
Ad Notification Serving Version 1:
npm start -- --enable-logging=stderr --vmodule="*/variations/*"=1,"*/bat-native-ads/*"=6,"*/brave_ads/*"=6,"*/bat_ads/*"=6
Ad Notification Serving Version 2:
npm start -- --enable-logging=stderr --vmodule="*/variations/*"=1,"*/bat-native-ads/*"=6,"*/brave_ads/*"=6,"*/bat_ads/*"=6 --enable-features=AdServing:ad_serving_version/2
Inline Content Ad Serving Version 1:
npm start -- --enable-logging=stderr --vmodule="*/variations/*"=1,"*/bat-native-ads/*"=6,"*/brave_ads/*"=6,"*/bat_ads/*"=6
Inline Content Ad Serving Version 2:
npm start -- --enable-logging=stderr --vmodule="*/variations/*"=1,"*/bat-native-ads/*"=6,"*/brave_ads/*"=6,"*/bat_ads/*"=6 --enable-features=AdServing:ad_serving_version/2