Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Brave Ads Serving Improvements #17236

Closed
moritzhaller opened this issue Jul 29, 2021 · 2 comments · Fixed by brave/brave-core#9736
Closed

Implement Brave Ads Serving Improvements #17236

moritzhaller opened this issue Jul 29, 2021 · 2 comments · Fixed by brave/brave-core#9736
Assignees
@moritzhaller
Labels
1_point For Agile sizing enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.32.x - Release

Comments

@moritzhaller
Copy link

No description provided.

@moritzhaller moritzhaller self-assigned this Jul 29, 2021
@moritzhaller moritzhaller added feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop OS/iOS Fixes related to iOS browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude enhancement labels Jul 29, 2021
@moritzhaller moritzhaller changed the title Improve Ad serving pipeline Improve ad notification serving pipeline Jul 29, 2021
@tmancey tmancey removed OS/Android Fixes related to Android browser functionality OS/iOS Fixes related to iOS browser functionality labels Jul 30, 2021
@moritzhaller moritzhaller changed the title Improve ad notification serving pipeline Improve Brave Ads notification serving pipeline Aug 2, 2021
@moritzhaller moritzhaller mentioned this issue Aug 12, 2021
Merged
24 tasks
@moritzhaller moritzhaller changed the title Improve Brave Ads notification serving pipeline Implement Brave Ads Serving Improvements Aug 12, 2021
@tmancey tmancey mentioned this issue Aug 13, 2021
Closed
@jsecretan
Copy link

Sizing at 1 point

@moritzhaller moritzhaller added this to the 1.32.x - Nightly milestone Sep 23, 2021
@jsecretan jsecretan added the 1_point For Agile sizing label Oct 5, 2021
@tmancey tmancey mentioned this issue Oct 26, 2021
Merged
@btlechowski
Copy link

Verification passed on

Brave 1.32.90 Chromium: 95.0.4638.69 (Official Build) beta (64-bit)
Revision 6a1600ed572fedecd573b6c2b90a22fe6392a410-refs/branch-heads/4638@{#984}
OS Ubuntu 18.04 LTS

Ad Notification v1

Notification ads

[2681:2681:1105/210313.956121:VERBOSE1:ad_notification_serving.cc(117)] Ad serving version 1
[2681:2681:1105/210313.957242:VERBOSE1:eligible_ad_notifications.cc(160)] Get eligible ads for parent-child segments:
[2681:2681:1105/210313.957327:VERBOSE1:eligible_ad_notifications.cc(162)]   technology & computing-software
[2681:2681:1105/210313.957380:VERBOSE1:eligible_ad_notifications.cc(162)]   technology & computing-technology & computing
[2681:2681:1105/210313.957440:VERBOSE1:eligible_ad_notifications.cc(162)]   business-business
[2681:2681:1105/210313.958163:VERBOSE1:eligible_ad_notifications.cc(173)] No eligible ads for parent-child segments
[2681:2681:1105/210313.958251:VERBOSE1:eligible_ad_notifications.cc(194)] Get eligible ads for parent segments:
[2681:2681:1105/210313.958302:VERBOSE1:eligible_ad_notifications.cc(196)]   technology & computing
[2681:2681:1105/210313.958361:VERBOSE1:eligible_ad_notifications.cc(196)]   business
[2681:2681:1105/210313.958409:VERBOSE1:eligible_ad_notifications.cc(196)]   food & drink
[2681:2681:1105/210313.958979:VERBOSE1:eligible_ad_notifications.cc(207)] No eligible ads for parent segments
[2681:2681:1105/210313.959063:VERBOSE1:eligible_ad_notifications.cc(219)] Get eligible ads for untargeted segment
[2681:2681:1105/210313.963205:VERBOSE2:exclusion_rule_util.h(27)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b excluded as not associated with advertiser split test group
[2681:2681:1105/210313.963847:VERBOSE2:exclusion_rule_util.h(27)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b excluded as not associated with advertiser split test group
[2681:2681:1105/210313.972420:VERBOSE2:ad_priority.h(32)] 13 ads with a priority of 1 in bucket 1
[2681:2681:1105/210313.972739:VERBOSE1:ad_notification_serving.cc(154)] Found 13 eligible ads
[2681:2681:1105/210313.972821:VERBOSE1:ad_notification_serving.cc(278)] Serving ad notification:
  uuid: 5fba1eb3-b13a-4347-9380-d6f499ed4fb6
  creativeInstanceId: 87173187-acb2-432b-a18d-a235f15f1c1c
  creativeSetId: 45ea5952-37ca-41f0-88c2-4b546b0e6f4b
  campaignId: 1c1ac828-db13-49bb-9128-090132044b7f
  advertiserId: ecbcc833-8b1d-4867-98f7-ad2341396ce8
  segment: untargeted
  title: Ad7
  body: Ad7
  targetUrl: https://brave.com

Verified user is paid for the ad

[2681:2681:1105/210938.810579:VERBOSE1:redeem_unblinded_token.cc(53)] Redeem unblinded token
[2681:2681:1105/210938.810623:VERBOSE1:redeem_unblinded_token.cc(67)] CreateConfirmation
[2681:2681:1105/210938.810691:VERBOSE2:redeem_unblinded_token.cc(68)] POST /v1/confirmation/{confirmation_id}/{credential}
[2681:2681:1105/210938.811262:VERBOSE6:redeem_unblinded_token.cc(72)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/5db8832e-9db8-
  Content: {"blindedPaymentToken":"lCuBOMmeH119FygZzbAiPBFdr8oQxKSsgR3DR2xwjEs=","buildChannel":"beta","creativeInstanceId":"87173187-acb2-432b-a18d-a235f15f1c1c","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: kPost
[2681:2681:1105/210938.811526:VERBOSE1:confirmations.cc(115)] Retry failed confirmations in 0 hours, 7 minutes, 16 seconds at 9:16 PM
[2681:2681:1105/210939.394546:VERBOSE1:redeem_unblinded_token.cc(83)] OnCreateConfirmation
[2681:2681:1105/210939.394744:VERBOSE6:redeem_unblinded_token.cc(85)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/5db8832e-9db8-
  Response Status Code: 201
  Response: {"id":"5db8832e-9db8-4de8-9409-b47d71c338be",
[2681:2681:1105/210939.394995:VERBOSE1:redeem_unblinded_token.cc(111)] FetchPaymentToken
[2681:2681:1105/210939.395099:VERBOSE2:redeem_unblinded_token.cc(112)] GET /v1/confirmation/{confirmation_id}/paymentToken
[2681:2681:1105/210939.395190:VERBOSE6:redeem_unblinded_token.cc(116)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/5db8832e-9db8-4de8-9409-b47d71c338be/paymentToken
  Method: kGet
[2681:2681:1105/210939.634107:VERBOSE1:redeem_unblinded_token.cc(127)] OnFetchPaymentToken
[2681:2681:1105/210939.634315:VERBOSE6:redeem_unblinded_token.cc(129)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/5db8832e-9db8-4de8-9409-b47d71c338be/paymentToken
  Response Status Code: 200
  Response: {"id":"5db8832e-9db8-4de8-9409-b47d71c338be",
[2681:2681:1105/210939.634556:VERBOSE1:confirmations.cc(260)] Successfully redeemed unblinded token with confirmation id 5db8832e-9db8-4de8-9409-b47d71c338be, creative instance id 87173187-acb2-432b-a18d-a235f15f1c1c and view
[2681:2681:1105/210939.635121:VERBOSE1:confirmations.cc(283)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 1 unblinded payment tokens

Inline ads

Ad is served

[3485:3485:1105/211948.358080:VERBOSE1:inline_content_ad_serving.cc(68)] Ad serving version 1
[3485:3485:1105/211948.359404:VERBOSE1:eligible_inline_content_ads.cc(166)] Get eligible ads for parent-child segments:
[3485:3485:1105/211948.359470:VERBOSE1:eligible_inline_content_ads.cc(168)]   technology & computing-software
[3485:3485:1105/211948.359505:VERBOSE1:eligible_inline_content_ads.cc(168)]   technology & computing-technology & computing
[3485:3485:1105/211948.359524:VERBOSE1:eligible_inline_content_ads.cc(168)]   business-business
[3485:3485:1105/211948.360355:VERBOSE1:eligible_inline_content_ads.cc(180)] No eligible ads for parent-child segments
[3485:3485:1105/211948.360393:VERBOSE1:eligible_inline_content_ads.cc(202)] Get eligible ads for parent segments:
[3485:3485:1105/211948.360689:VERBOSE1:eligible_inline_content_ads.cc(204)]   technology & computing
[3485:3485:1105/211948.360714:VERBOSE1:eligible_inline_content_ads.cc(204)]   business
[3485:3485:1105/211948.360746:VERBOSE1:eligible_inline_content_ads.cc(204)]   food & drink
[3485:3485:1105/211948.361639:VERBOSE1:eligible_inline_content_ads.cc(216)] No eligible ads for parent segments
[3485:3485:1105/211948.361674:VERBOSE1:eligible_inline_content_ads.cc(229)] Get eligible ads for untargeted segment
[3485:3485:1105/211948.364876:VERBOSE2:ad_priority.h(32)] 2 ads with a priority of 1 in bucket 1
[3485:3485:1105/211948.364937:VERBOSE1:inline_content_ad_serving.cc(104)] Found 2 eligible ads
[3485:3485:1105/211948.364977:VERBOSE1:inline_content_ad_serving.cc(129)] Serving inline content ad:
  uuid: 94674d73-d5f0-49c1-9de9-fab31b0a0367
  creativeInstanceId: 033a95ca-963b-460c-b203-8181346bd41c
  creativeSetId: 6c875e23-00ea-4f1b-805b-5d52559f96da
  campaignId: 8a5ca6f0-f919-461b-8bf2-4848e34ab616
  advertiserId: aa1d1cdb-ec45-42d4-86d0-ea353e1babd4
  segment: untargeted
  title: Makita LF1000 Flip Over Saw
  description: Makita
  imageUrl: https://pcdn.bravesoftware.com/brave-ads/image-1.jpg.pad
  dimensions: 900x750
  ctaText: Learn more
  targetUrl: https://www.powertools2u.co.uk/makita-lf1000-flip-over-sawo
[3485:3485:1105/211948.366486:VERBOSE3:inline_content_ad_event_served.cc(24)] Served inline content ad with uuid 94674d73-d5f0-49c1-9de9-fab31b0a0367 and creative instance id 033a95ca-963b-460c-b203-8181346bd41c
[3485:3485:1105/211948.408872:VERBOSE1:inline_content_ad_event_served.cc(32)] Successfully logged inline content ad served event

user is paid:

[3485:3485:1105/211948.408872:VERBOSE1:inline_content_ad_event_served.cc(32)] Successfully logged inline content ad served event
[3485:3485:1105/211954.774426:VERBOSE3:inline_content_ad_event_viewed.cc(24)] Viewed inline content ad with uuid 94674d73-d5f0-49c1-9de9-fab31b0a0367 and creative instance id 033a95ca-963b-460c-b203-8181346bd41c
[3485:3485:1105/211954.774804:VERBOSE1:confirmations.cc(93)] Confirming view for creative instance id 033a95ca-963b-460c-b203-8181346bd41c
[3485:3485:1105/211954.783352:VERBOSE1:redeem_unblinded_token.cc(53)] Redeem unblinded token
[3485:3485:1105/211954.783388:VERBOSE1:redeem_unblinded_token.cc(67)] CreateConfirmation
[3485:3485:1105/211954.783488:VERBOSE2:redeem_unblinded_token.cc(68)] POST /v1/confirmation/{confirmation_id}/{credential}
[3485:3485:1105/211954.783511:VERBOSE6:redeem_unblinded_token.cc(72)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/04a6bfcd-cbb
  Content: {"blindedPaymentToken":"pqm6I8MUygcczHkZfDcI2jbDQjHk20HGs35hB7vloxw=","buildChannel":"beta","creativeInstanceId":"033a95ca-963b-460c-b203-8181346bd41c","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: kPost
[3485:3485:1105/211954.788994:VERBOSE6:inline_content_ad_event_viewed.cc(32)] Successfully logged inline content ad viewed event
[3485:3485:1105/211955.308862:VERBOSE1:redeem_unblinded_token.cc(83)] OnCreateConfirmation
[3485:3485:1105/211955.308966:VERBOSE6:redeem_unblinded_token.cc(85)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/
  Response Status Code: 201
  Response: {"id":"04a6bfcd-cbb8-43da-badb-435a8d5e0b41","payload":{},
[3485:3485:1105/211955.309080:VERBOSE1:redeem_unblinded_token.cc(111)] FetchPaymentToken
[3485:3485:1105/211955.309131:VERBOSE2:redeem_unblinded_token.cc(112)] GET /v1/confirmation/{confirmation_id}/paymentToken
[3485:3485:1105/211955.309173:VERBOSE6:redeem_unblinded_token.cc(116)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/04a6bfcd-cbb8-43da-badb-435a8d5e0b41/paymentToken
  Method: kGet
[3485:3485:1105/211955.787996:VERBOSE1:redeem_unblinded_token.cc(127)] OnFetchPaymentToken
[3485:3485:1105/211955.788054:VERBOSE6:redeem_unblinded_token.cc(129)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/04a6bfcd-cbb8-43da-badb-435a8d5e0b41/paymentToken
  Response Status Code: 200
  Response: {"id":"04a6bfcd-cbb8-43da-badb-435a8d5e0b41",
[3485:3485:1105/211955.788108:VERBOSE1:confirmations.cc(260)] Successfully redeemed unblinded token with confirmation id 04a6bfcd-cbb8-43da-badb-435a8d5e0b41, creative instance id 033a95ca-963b-460c-b203-8181346bd41c and view
[3485:3485:1105/211955.788242:VERBOSE1:confirmations.cc(283)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 3 unblinded payment tokens

Ad Notification v2

Notification ads

ad is shown

[5390:5390:1112/213053.003275:VERBOSE1:ad_notification_serving.cc(117)] Ad serving version 2
[5390:5390:1112/213053.003344:VERBOSE1:text_classification_model.cc(86)] No text classification probabilities found for en_US.UTF-8 locale
[5390:5390:1112/213053.004186:VERBOSE1:eligible_ad_notifications.cc(103)] Get eligible ads
[5390:5390:1112/213053.021422:VERBOSE2:exclusion_rule_util.h(27)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b excluded as not associated with advertiser split test group
[5390:5390:1112/213053.038734:VERBOSE2:exclusion_rule_util.h(27)] creativeSetId cfaa9b82-3bdc-4fa1-ac03-0023cc7a3830 excluded as not within a scheduled time slot
[5390:5390:1112/213053.045935:VERBOSE2:exclusion_rule_util.h(27)] creativeSetId c7e7a381-4c74-4dd9-9b6d-4edf9330454b excluded as not associated with advertiser split test group
[5390:5390:1112/213053.120291:VERBOSE1:ad_notification_serving.cc(278)] Serving ad notification:
  uuid: 06888aea-6e78-4398-a9e8-1a16e7de5aaa
  creativeInstanceId: 30ecd70f-f56d-4745-a457-4035fcab54b6
  creativeSetId: 0a697a3b-233a-44bc-a337-e2441fb277a7
  campaignId: d4d0474c-277a-4714-b25d-7b484cdb580a
  advertiserId: 8d2f4191-b76e-4369-8983-3d9ff551c5ad
  segment: untargeted
  title: This is a test
  body: This is a test
  targetUrl: https://www.brave.com

user is paid for it

[5390:5390:1112/214335.681353:VERBOSE1:redeem_unblinded_token.cc(53)] Redeem unblinded token
[5390:5390:1112/214335.681385:VERBOSE1:redeem_unblinded_token.cc(67)] CreateConfirmation
[5390:5390:1112/214335.681407:VERBOSE2:redeem_unblinded_token.cc(68)] POST /v1/confirmation/{confirmation_id}/{credential}
[5390:5390:1112/214335.681959:VERBOSE6:redeem_unblinded_token.cc(72)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/65684c18-c791
  Content: {"blindedPaymentToken":"4o8Qd2R9biGypC85JW3Co1a6hM9DJvpnnTtodGSuBxM=","buildChannel":"beta","creativeInstanceId":"30ecd70f-f56d-4745-a457-4035fcab54b6","payload":{},"platform":"linux","studies":[],"type":"view"}
  Content Type: application/json
  Method: kPost
[5390:5390:1112/214335.682300:VERBOSE1:confirmations.cc(115)] Retry failed confirmations in 0 hours, 0 minutes, 3 seconds at 9:43 PM
[5390:5390:1112/214336.268635:VERBOSE1:redeem_unblinded_token.cc(83)] OnCreateConfirmation
[5390:5390:1112/214336.268673:VERBOSE6:redeem_unblinded_token.cc(85)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/65684c18-c791-
  Response Status Code: 201
  Response: {"id":"65684c18-c791-439b-be30-454554c8fc14","payload":{},
[5390:5390:1112/214336.268717:VERBOSE1:redeem_unblinded_token.cc(111)] FetchPaymentToken
[5390:5390:1112/214336.268747:VERBOSE2:redeem_unblinded_token.cc(112)] GET /v1/confirmation/{confirmation_id}/paymentToken
[5390:5390:1112/214336.268872:VERBOSE6:redeem_unblinded_token.cc(116)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/65684c18-c791-
  Method: kGet
[5390:5390:1112/214336.542268:VERBOSE1:redeem_unblinded_token.cc(127)] OnFetchPaymentToken
[5390:5390:1112/214336.542304:VERBOSE6:redeem_unblinded_token.cc(129)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/65684c18-c791-439b-be30-454554c8fc14/paymentToken
  Response Status Code: 200
  Response: {"id":"65684c18-c791-439b-be30-454554c8fc14",
[5390:5390:1112/214336.543359:VERBOSE1:confirmations.cc(260)] Successfully redeemed unblinded token with confirmation id 65684c18-c791-439b-be30-454554c8fc14, creative instance id 30ecd70f-f56d-4745-a457-4035fcab54b6 and view
[5390:5390:1112/214336.543914:VERBOSE1:confirmations.cc(283)] Added 1 unblinded payment token with an estimated redemption value of 0.025 BAT, you now have 1 unblinded payment tokens

Inline ads

Ad was served

[6934:6934:1112/060636.881807:VERBOSE1:inline_content_ad_serving.cc(68)] Ad serving version 2
[6934:6934:1112/060636.881866:VERBOSE1:text_classification_model.cc(86)] No text classification probabilities found for en_US.UTF-8 locale
[6934:6934:1112/060636.889762:VERBOSE1:eligible_inline_content_ads.cc(106)] Get eligible ads
[6934:6934:1112/060636.898270:VERBOSE1:inline_content_ad_serving.cc(174)] Serving inline content ad:
  uuid: 8662f449-b647-470b-8280-73a3eef19a8a
  creativeInstanceId: e4958d00-e35c-4134-a408-1fbcf274d5ae
  creativeSetId: 8b848823-c47f-43de-a753-2efa8dea6863
  campaignId: 07de7f05-ab32-4af0-a350-a1bce4427eac
  advertiserId: 93130af3-2def-4ecb-b836-b3772e73b3c9
  segment: untargeted
  title: Staging - Inline Test 1
  description: Fung Brave News Inline Display Ad - mac/linux
  imageUrl: https://pcdn.brave.com/brave-ads/468beb93-2458-5d3e-8d7b-bc1f387d2e9b.webp.pad
  dimensions: 900x750
  ctaText: Work at Brave
  targetUrl: https://brave.com/careers
[6934:6934:1112/060636.905912:VERBOSE3:inline_content_ad_event_served.cc(24)] Served inline content ad with uuid 8662f449-b647-470b-8280-73a3eef19a8a and creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae
[6934:6934:1112/060636.917189:VERBOSE1:inline_content_ad_event_served.cc(32)] Successfully logged inline content ad served event

User was paid for it

[6934:6934:1112/060927.594729:VERBOSE1:redeem_unblinded_token.cc(83)] OnCreateConfirmation
[6934:6934:1112/060927.594823:VERBOSE6:redeem_unblinded_token.cc(85)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/8608d6a
  Response Status Code: 201
  Response: {"id":"8608d6a1-8ad7-452d-90ca-59c7e6bad335","payload":{},
[6934:6934:1112/060927.595656:VERBOSE1:redeem_unblinded_token.cc(111)] FetchPaymentToken
[6934:6934:1112/060927.595738:VERBOSE2:redeem_unblinded_token.cc(112)] GET /v1/confirmation/{confirmation_id}/paymentToken
[6934:6934:1112/060927.595795:VERBOSE6:redeem_unblinded_token.cc(116)] URL Request:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/8608d6a1-8ad7-452d-90ca-59c7e6bad335/paymentToken
  Method: kGet
[6934:6934:1112/060927.808162:VERBOSE1:redeem_unblinded_token.cc(127)] OnFetchPaymentToken
[6934:6934:1112/060927.808248:VERBOSE6:redeem_unblinded_token.cc(129)] URL Response:
  URL: https://ads-serve.bravesoftware.com/v1/confirmation/8608d6a1-8ad7-452d-90ca-59c7e6bad335/paymentToken
  Response Status Code: 200
  Response: {"id":"8608d6a1-8ad7-452d-90ca-59c7e6bad335",
[6934:6934:1112/060927.809213:VERBOSE1:confirmations.cc(260)] Successfully redeemed unblinded token with confirmation id 8608d6a1-8ad7-452d-90ca-59c7e6bad335, creative instance id e4958d00-e35c-4134-a408-1fbcf274d5ae and view
[6934:6934:1112/060927.809689:VERBOSE1:confirmations.cc(283)] Added 1 unblinded payment token with an estimated redemption value of 0.01 BAT, you now have 1 unblinded payment tokens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@moritzhaller moritzhaller

Labels
1_point For Agile sizing enhancement feature/ads OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Milestone
1.32.x - Release
Development

Successfully merging a pull request may close this issue.

Implement Brave Ads Serving Improvements brave/brave-core
4 participants
@jsecretan @tmancey @moritzhaller @btlechowski