Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set sync to default enabled and provide "disable-brave-sync" switch #943

Merged
merged 1 commit into from
Nov 22, 2018

Conversation

darkdh
Copy link
Member

@darkdh darkdh commented Nov 21, 2018

fix brave/brave-browser#2208

Submitter Checklist:

  • Submitted a ticket for my issue if one did not already exist.
  • Used Github auto-closing keywords in the commit message.
  • Added/updated tests for this change (for new code or code which already has tests).
  • Verified that these changes build without errors on
    • Windows
    • macOS
    • Linux
  • Verified that these changes pass automated tests (npm test brave_unit_tests && npm test brave_browser_tests) on
    • Windows
    • macOS
    • Linux
  • Ran git rebase master (if needed).
  • Ran git rebase -i to squash commits (if needed).
  • Tagged reviewers and labelled the pull request as needed.
  • Request a security/privacy review as needed.
  • Add appropriate QA labels (QA/Yes or QA/No) to include the closed issue in milestone

Test Plan:

  1. npm run test -- brave_unit_tests --filter=BraveSyncServiceTest.*
  2. Sync should be accessible without any switches
  3. Execute Brave with "disable-brave-sync", sync option shouldn't appear on menu and also sync extension is disabled

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

@SergeyZhukovsky
Copy link
Member

looks good to me, but I'm not sure I'm familiar with command line switches

Copy link
Member

@bbondy bbondy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, please merge up to 0.58.x

@darkdh darkdh merged commit ac3b567 into master Nov 22, 2018
darkdh added a commit that referenced this pull request Nov 22, 2018
Set sync to default enabled and provide "disable-brave-sync" switch
@darkdh
Copy link
Member Author

darkdh commented Nov 22, 2018

master: ac3b567
0.58.x: 2f0974c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Sync by default
3 participants