Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make wayback url request to use per-profile SharedLoaderFactory #4763

Merged
merged 1 commit into from
Feb 27, 2020

Conversation

simonhong
Copy link
Member

@simonhong simonhong commented Feb 26, 2020

With this factory, traffic to the Internet Archive will use tor
proxy in private(tor). and set cookie disallowed.

Resolves brave/brave-browser#8419

Submitter Checklist:

Test Plan:

  1. Launch tor window
  2. Load www.brave.com/bo
  3. Capture network request by using wireshark or any other network intercepter
  4. Verify that traffic to the Internet Archive(brave-api.archive.org) uses tor proxy
  5. With Charles intercepter, it can't capture brave-api.archive.org url request.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@simonhong simonhong self-assigned this Feb 26, 2020
@simonhong simonhong added this to the 1.7.x - Nightly milestone Feb 26, 2020
@simonhong simonhong marked this pull request as ready for review February 26, 2020 23:33
With this factory, traffic to the Internet Archive will use tor
proxy in private(tor). and set cookie disallowed.
@simonhong simonhong added CI/skip-ios Do not run CI builds for iOS CI/skip-linux and removed CI/skip-ios Do not run CI builds for iOS CI/skip-linux labels Feb 27, 2020
@kjozwiak
Copy link
Member

kjozwiak commented Mar 2, 2020

Reproduced the original issue on macOS 10.15.3 x64 using the following build:

Brave 1.7.22 Chromium: 80.0.3987.122 (Official Build) nightly (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.15.3 (Build 19D76)

When visiting https://brave.com/bo in a Tor window and selecting Check for saved version, you'll notice that https://brave-api.archive.org is being listed in Charles.

Screen Shot 2020-03-02 at 1 53 52 PM

Verification PASSED on macOS 10.15.3 x64 using the following build:

Brave 1.7.32 Chromium: 80.0.3987.122 (Official Build) nightly (64-bit)
Revision cf72c4c4f7db75bc3da689cd76513962d31c7b52-refs/branch-heads/3987@{#943}
OS macOS Version 10.15.3 (Build 19D76)

Basically ensured that https://brave-api.archive.org/ isn't being listed in Charles Proxy when using the Tor window. Double checked with @simonhong and ensured that's the expected behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wayback machine feature should be disabled in Tor windows or use Tor
3 participants